fix: allow discoverable credentials login without PIN#158
Closed
forkline-bot[bot] wants to merge 1 commit intomasterfrom
Closed
fix: allow discoverable credentials login without PIN#158forkline-bot[bot] wants to merge 1 commit intomasterfrom
forkline-bot[bot] wants to merge 1 commit intomasterfrom
Conversation
The authenticator was incorrectly configured with always_uv=true and client_pin=None, which blocked all credential operations when no PIN was set. Changed to client_pin=Some(false) to indicate PIN support without a configured PIN, and always_uv=Some(false) to allow authentication via notification-based user presence. This enables passkey login on sites like GitHub/GitLab that use discoverable credentials without requiring username input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes discoverable credentials (passkey) login by correcting the
AuthenticatorOptionsconfiguration.Root Cause
The authenticator was configured with:
always_uv: Some(true)- requiring user verification for ALL operationsclient_pin: None- indicating no PIN support availableWhen no PIN is set, the soft-fido2 handler returns
OperationDeniedbecause it requires UV but the authenticator is not protected by UV. This blocked all credential operations, including discoverable credential authentication.Changes
client_pin: None→client_pin: Some(false)- PIN is supported but not currently setalways_uv: Some(true)→always_uv: Some(false)- Allow operations without UV, relying on notification-based user presenceTesting
This enables passkey login on sites like GitHub/GitLab that use discoverable credentials without requiring username input.
Resolves: #157