fix: allow discoverable credentials without UV requirement#164
Closed
forkline-bot[bot] wants to merge 1 commit intomasterfrom
Closed
fix: allow discoverable credentials without UV requirement#164forkline-bot[bot] wants to merge 1 commit intomasterfrom
forkline-bot[bot] wants to merge 1 commit intomasterfrom
Conversation
- Set uv: None to not claim built-in UV support (desktop notifications are used instead) - Set client_pin: Some(false) to indicate PIN is supported but not set - Set always_uv: None to allow operations without mandatory UV This fixes passkey login without username by allowing the authentication flow to proceed via user presence callback instead of requiring biometric UV which passless doesn't have. Resolves: #157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv: Some(true)touv: Noneto not claim built-in UV support (passless uses desktop notifications instead of biometrics)client_pin: Nonetoclient_pin: Some(false)to indicate PIN is supported but not currently setalways_uv: Some(true)toalways_uv: Noneto allow operations without mandatory UVBackground
This fixes passkey login without username (discoverable credentials) by allowing the authentication flow to proceed via user presence callback instead of requiring biometric UV which passless doesn't have.
When users click "Sign in with passkey" on sites like GitHub/GitLab, the browser sends GetAssertion with an empty allowList. The previous configuration required UV (
always_uv: Some(true)) while claiming built-in UV support (uv: Some(true)), but since passless uses desktop notifications for verification (not true biometric UV), this caused operations to be denied.Testing
This change allows the authentication flow to:
request_upcallback for user presence verification via desktop notificationsResolves: #157