fixed crop_frames for robustness#57
Merged
themattinthehatt merged 4 commits intomainfrom Nov 12, 2025
Merged
Conversation
Collaborator
keeminlee
commented
Nov 10, 2025
- Adds crop_frames utility for flexible frame subsetting using 1-based (start, end) tuples with optional open-ended bounds (None).
- Implements strict input validation (no overlaps, out-of-bounds, or invalid types) and consistent NumPy slicing semantics.
- Includes unit tests verifying correct cropping, open-ended behavior, and error handling for invalid inputs.
themattinthehatt
requested changes
Nov 11, 2025
Collaborator
themattinthehatt
left a comment
There was a problem hiding this comment.
let's make the ranges match how python would process, i.e. 0-based, left-inclusive, right-exclusive
themattinthehatt
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.