Skip to content

feat: adding global envoy policies option#422

Merged
jmpalomares merged 4 commits intomainfrom
feat/global-envoy-policies
Mar 10, 2026
Merged

feat: adding global envoy policies option#422
jmpalomares merged 4 commits intomainfrom
feat/global-envoy-policies

Conversation

@jmpalomares
Copy link
Contributor

@jmpalomares jmpalomares commented Mar 9, 2026

Description

Global Envoy Policy Defaults

  • Added global envoy.backendTrafficPolicy and envoy.clientTrafficPolicy support in _httproutes.tp
  • Per-route policies override global defaults.
  • Documented global policy blocks in values.yaml

Tested and verified in product-api staging

Checklist

  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copilot AI review requested due to automatic review settings March 9, 2026 09:00
@jmpalomares jmpalomares requested review from a team as code owners March 9, 2026 09:00
@github-actions github-actions bot added the yaml label Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for chart-wide (global) Envoy Gateway policy defaults so users can define envoy.backendTrafficPolicy / envoy.clientTrafficPolicy once and have them applied to all HTTPRoutes, with per-route configuration overriding the global settings.

Changes:

  • Implement global default + per-route override merge logic for Envoy BackendTrafficPolicy and ClientTrafficPolicy generation.
  • Document the new global policy blocks in microservice and monolith values.yaml.
  • Bump chart versions for common, microservice, and monolith.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
parcellab/common/templates/_httproutes.tpl Merges global Envoy policy defaults into each route (deep copy + mergeOverwrite), then renders policies from the merged route.
parcellab/microservice/values.yaml Adds commented examples documenting envoy.backendTrafficPolicy and envoy.clientTrafficPolicy global defaults.
parcellab/monolith/values.yaml Adds commented examples documenting envoy.backendTrafficPolicy and envoy.clientTrafficPolicy global defaults.
parcellab/common/Chart.yaml Bumps library chart version to reflect new template capability.
parcellab/microservice/Chart.yaml Bumps chart version for the feature release.
parcellab/monolith/Chart.yaml Bumps chart version for the feature release.

Copy link
Contributor

@kpplis kpplis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too complex and nested for me to actually understand what it does, so hope you tested it

Copy link
Contributor

@andibeuge andibeuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - we could reduce the complexity by merging the almost identical templates. Funktioniert wise it looks good

@jmpalomares jmpalomares merged commit 964e70d into main Mar 10, 2026
5 checks passed
@jmpalomares jmpalomares deleted the feat/global-envoy-policies branch March 10, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants