update rand package to 0.8.3

[girazoki]

This PR updates the rand package to 0.8.3, which does not require the i128 support and grabs the StdRng from rand::rngs.

[JoshOrndorff]

This will avoid nasty version confusion similar to rust-random/rand#645 when using this in Frontier precompiles https://github.com/paritytech/frontier/tree/master/frame/evm/precompile/bn128

[niklasad1]

this dev-feature will be leaked into features but it was like that before so probably fine.

[niklasad1]

LGTM

[ordian]

There is an alternative PR #18, I don't have a strong opinion on this, @NikVolf could you take a look?

Also the latest published version of substrate-bn is 0.5.0, which doesn't match what's in master, so I don't know if there any other changes that are also not master? I mention this, because this change is breaking.

Other than that, no objection from me to merge this.

[dvdplm]

There is an alternative PR #18, I don't have a strong opinion on this, @NikVolf could you take a look?

#18 seems to do a bit more than this one and while not completely orthogonal, it seems to me like we might want to have both this one and that one.

So this lgtm.

[ordian]

#18 seems to do a bit more than this one and while not completely orthogonal, it seems to me like we might want to have both this one and that one.

I say it's an alternative, because it removes the rand dependency and adds a dependency on more stable rand_core (which is at 0.6 version compared to 0.8 rand). So with #18 we don't actually need this PR.

[girazoki]

For us its fine either this PR or #18, as both of them remove the dependency of rand 0.5.6 which is the source of our issues with the bn128 precompiles. Let us know whether you finally want this to be merged or #18. From what I see there are some minor cosmetic changes between the version that was published for substrate (which I assume is the nv-publish-for-substrate branch) and master, but if you prefer I can PR that branch instead.

[dvdplm]

Good pt about rand_core. I now have a slight preference for #18, let's merge that.

[ordian]

@dvdplm feel free to take over that PR and resolve conflicts, I'm inclined to publish after #22 is merged and leave for later though

@girazoki can publish as soon as @NikVolf adds paritytech as crate owners

[ordian]

I'll publish it soon if there are no objections.

UPD: published 0.6.0.

[girazoki]

Good for me!