feat: Send client key in the connect operation#118
Open
JoshuaBradbury wants to merge 2 commits intoparse-community:masterfrom
Open
feat: Send client key in the connect operation#118JoshuaBradbury wants to merge 2 commits intoparse-community:masterfrom
JoshuaBradbury wants to merge 2 commits intoparse-community:masterfrom
Conversation
Member
|
Thanks for this PR, it even includes a test - amazing! Let's wait for another review, and when the CI passes, it should be good to merge. Unfortunately this repo has not been upgraded to auto-release yet and still uses TravisCI. That's something we have to look into as well to release a version with this feature. See #122 |
mtrezza
changed the title
Thanks for opening this pull request!
|
azlekov
approved these changes
Dec 22, 2022
Comment on lines
+433
to
+440
| parseLiveQueryClient = ParseLiveQueryClient.Factory.getClient(new URI(""), new WebSocketClientFactory() { | ||
| @Override | ||
| public WebSocketClient createInstance(WebSocketClient.WebSocketClientCallback webSocketClientCallback, URI hostUrl) { | ||
| TestParseLiveQueryClient.this.webSocketClientCallback = webSocketClientCallback; | ||
| webSocketClient = mock(WebSocketClient.class); | ||
| return webSocketClient; | ||
| } | ||
| }, new ImmediateExecutor()); |
There was a problem hiding this comment.
Is there any reason why you explicitly change the instance from @Before?
The initialization looks same to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For parse setups that use a client key, the live query client will never connect appropriately as the android library doesn't pass in the client key.
See: parse-community/ParseLiveQuery-iOS-OSX#136