Merged
Conversation
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
6c88df2 to
3796db9
Compare
efef5a8 to
8258f60
Compare
DanielBadura
approved these changes
Feb 12, 2026
Member
DanielBadura
left a comment
There was a problem hiding this comment.
LGTM, maybe add some more tests as we have on the diff only a coverage of 40%. That is pretty low
DanielBadura
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #806
Add an alternative way to clean up subscriptions without requiring the subscriber to still exist in the code.
When creating a subscription, the engine checks if a cleanup method exists. If so, it is called, and the cleanup tasks, along with other metadata, are stored in the subscription store. When the subscriber is removed, instead of executing the teardown method, the tasks from the store are used, and the corresponding handlers are called. This eliminates the need for the subscriber code itself. By default, we have added two tasks for Doctrine/dbal:
DropTableTaskandDropIndexTask. It is extensible. Users can also create their own tasks and handlers, for example, if they are using MongoDB.