Skip to content

Add nullable information to Subscriber ArgumentMetadata #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielBadura merged 1 commit into from
Feb 10, 2026
+48 −21
Merged

Add nullable information to Subscriber ArgumentMetadata #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ parameters:
path: tests/Unit/Message/Translator/ReplaceEventTranslatorTest.php

-
message: '#^Method class@anonymous/tests/Unit/Metadata/Subscriber/AttributeSubscriberMetadataFactoryTest\.php\:212\:\:profileVisited\(\) has parameter \$message with no type specified\.$#'
message: '#^Method class@anonymous/tests/Unit/Metadata/Subscriber/AttributeSubscriberMetadataFactoryTest\.php\:237\:\:profileVisited\(\) has parameter \$message with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: tests/Unit/Metadata/Subscriber/AttributeSubscriberMetadataFactoryTest.php
Expand Down
1 change: 1 addition & 0 deletions src/Metadata/Subscriber/ArgumentMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ final class ArgumentMetadata
public function __construct(
public readonly string $name,
public readonly string $type,
public readonly bool $allowsNull = false,
) {
}
}
1 change: 1 addition & 0 deletions src/Metadata/Subscriber/AttributeSubscriberMetadataFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ private function subscribeMethod(ReflectionMethod $method): SubscribeMethodMetad
$arguments[] = new ArgumentMetadata(
$parameter->getName(),
$type->getName(),
$parameter->allowsNull(),
);
}

Expand Down
31 changes: 28 additions & 3 deletions tests/Unit/Metadata/Subscriber/AttributeSubscriberMetadataFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,38 @@ public function profileCreated(ProfileCreated $profileCreated, string $aggregate
[
ProfileVisited::class => [
new SubscribeMethodMetadata('profileVisited', [
new ArgumentMetadata('message', Message::class),
new ArgumentMetadata('message', Message::class, false),
]),
],
ProfileCreated::class => [
new SubscribeMethodMetadata('profileCreated', [
new ArgumentMetadata('profileCreated', ProfileCreated::class),
new ArgumentMetadata('aggregateId', 'string'),
new ArgumentMetadata('profileCreated', ProfileCreated::class, false),
new ArgumentMetadata('aggregateId', 'string', false),
]),
],
],
$metadata->subscribeMethods,
);
}

public function testSubscribeNullableAttribute(): void
{
$subscriber = new #[Subscriber('foo', RunMode::FromBeginning)]
class {
#[Subscribe(ProfileVisited::class)]
public function profileVisited(ProfileVisited|null $message): void
{
}
};

$metadataFactory = new AttributeSubscriberMetadataFactory();
$metadata = $metadataFactory->metadata($subscriber::class);

self::assertEquals(
[
ProfileVisited::class => [
new SubscribeMethodMetadata('profileVisited', [
new ArgumentMetadata('message', ProfileVisited::class, true),
]),
],
],
Expand Down
8 changes: 4 additions & 4 deletions tests/Unit/Subscription/Subscriber/ArgumentResolver/AggregateIdArgumentResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,21 @@ public function testSupport(): void

self::assertTrue(
$resolver->support(
new ArgumentMetadata('aggregateId', Uuid::class),
new ArgumentMetadata('aggregateId', Uuid::class, false),
ProfileCreated::class,
),
);

self::assertTrue(
$resolver->support(
new ArgumentMetadata('aggregateRootId', ProfileId::class),
new ArgumentMetadata('aggregateRootId', ProfileId::class, false),
ProfileCreated::class,
),
);

self::assertFalse(
$resolver->support(
new ArgumentMetadata('foo', ProfileCreated::class),
new ArgumentMetadata('foo', ProfileCreated::class, false),
ProfileCreated::class,
),
);
Expand All @@ -58,7 +58,7 @@ public function testResolve(): void
self::assertEquals(
new CustomId('bar'),
$resolver->resolve(
new ArgumentMetadata('foo', CustomId::class),
new ArgumentMetadata('foo', CustomId::class, false),
$message,
),
);
Expand Down
6 changes: 3 additions & 3 deletions tests/Unit/Subscription/Subscriber/ArgumentResolver/EventArgumentResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ public function testSupport(): void

self::assertTrue(
$resolver->support(
new ArgumentMetadata('foo', ProfileCreated::class),
new ArgumentMetadata('foo', ProfileCreated::class, false),
ProfileCreated::class,
),
);

self::assertFalse(
$resolver->support(
new ArgumentMetadata('foo', ProfileVisited::class),
new ArgumentMetadata('foo', ProfileVisited::class, false),
ProfileCreated::class,
),
);
Expand All @@ -45,7 +45,7 @@ public function testResolve(): void
self::assertSame(
$event,
$resolver->resolve(
new ArgumentMetadata('foo', ProfileVisited::class),
new ArgumentMetadata('foo', ProfileVisited::class, false),
$message,
),
);
Expand Down
6 changes: 3 additions & 3 deletions tests/Unit/Subscription/Subscriber/ArgumentResolver/LookupResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ public function testSupport(): void

self::assertTrue(
$resolver->support(
new ArgumentMetadata('lookup', Lookup::class),
new ArgumentMetadata('lookup', Lookup::class, false),
ProfileCreated::class,
),
);

self::assertFalse(
$resolver->support(
new ArgumentMetadata('foo', ProfileCreated::class),
new ArgumentMetadata('foo', ProfileCreated::class, false),
ProfileCreated::class,
),
);
Expand All @@ -61,7 +61,7 @@ public function testResolve(): void
);

$lookup = $resolver->resolve(
new ArgumentMetadata('foo', Lookup::class),
new ArgumentMetadata('foo', Lookup::class, false),
$message,
);

Expand Down
6 changes: 3 additions & 3 deletions tests/Unit/Subscription/Subscriber/ArgumentResolver/MessageArgumentResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ public function testSupport(): void

self::assertTrue(
$resolver->support(
new ArgumentMetadata('foo', Message::class),
new ArgumentMetadata('foo', Message::class, false),
'qux',
),
);

self::assertFalse(
$resolver->support(
new ArgumentMetadata('foo', 'bar'),
new ArgumentMetadata('foo', 'bar', false),
'qux',
),
);
Expand All @@ -41,7 +41,7 @@ public function testResolve(): void
self::assertSame(
$message,
$resolver->resolve(
new ArgumentMetadata('foo', Message::class),
new ArgumentMetadata('foo', Message::class, false),
$message,
),
);
Expand Down
8 changes: 4 additions & 4 deletions tests/Unit/Subscription/Subscriber/ArgumentResolver/RecordedOnArgumentResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ public function testSupport(): void

self::assertTrue(
$resolver->support(
new ArgumentMetadata('foo', DateTimeImmutable::class),
new ArgumentMetadata('foo', DateTimeImmutable::class, false),
'qux',
),
);

self::assertFalse(
$resolver->support(
new ArgumentMetadata('foo', 'bar'),
new ArgumentMetadata('foo', 'bar', false),
'qux',
),
);
Expand All @@ -53,7 +53,7 @@ public function testResolveFromAggregateHeader(): void
self::assertSame(
$date,
$resolver->resolve(
new ArgumentMetadata('foo', DateTimeImmutable::class),
new ArgumentMetadata('foo', DateTimeImmutable::class, false),
$message,
),
);
Expand All @@ -69,7 +69,7 @@ public function testResolveFromRecordedOnHeader(): void
self::assertSame(
$date,
$resolver->resolve(
new ArgumentMetadata('foo', DateTimeImmutable::class),
new ArgumentMetadata('foo', DateTimeImmutable::class, false),
$message,
),
);
Expand Down
Loading