Open
Conversation
ec29d9e to
abe4a5d
Compare
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
| $metadataFactory->metadata($subscriber::class); | ||
| } | ||
|
|
||
| public function testUnionTypeNotSupported(): void |
Member
There was a problem hiding this comment.
if we are now supporting these cases, we should cover them, no?
Member
Author
There was a problem hiding this comment.
In my opinion, that doesn't make sense, since we neither actively support it nor don't. We add the argument type to the argument metadata (this is tested), and the argument resolver decides whether something is supported (this is also tested). type info supports union types as well as collections, array shapes, etc. (we haven't tested this, we don't test the functionality of external code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
symfony/type-infofor the subscriber argument resolver. This is a further step to remove custom type logic and thus our limitations.