Refactor neuron changes to make it compatible with FS repo#4
Open
aws-mengchiy wants to merge 5 commits intomainfrom
Open
Refactor neuron changes to make it compatible with FS repo#4aws-mengchiy wants to merge 5 commits intomainfrom
aws-mengchiy wants to merge 5 commits intomainfrom
Conversation
axlearn/common/attention.py
Outdated
| ff_layer.linear1.output_partition_spec = (batch_axis_names, seq_axis_names, tp_axis_names) | ||
| ff_layer.linear2.output_partition_spec = (batch_axis_names, seq_axis_names, None) | ||
|
|
||
| if jax.default_backend() == "neuron": |
Owner
There was a problem hiding this comment.
shouldnt this line be before we create the specs above?
Collaborator
Author
There was a problem hiding this comment.
Yeah, looks like it should. Maybe python compiler plugs in the method inline so that I did not hit any error. But will move it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete unnecessary snippets and rewrite neuron changes to make it compatible with FS repo. It intends to minimize the neuron-specific changes we made as well.