Skip to content

Filter out empty CloudFront cookies#19

Closed
math63 wants to merge 1 commit intopatrickziegler:mainfrom
math63:math63-patch-1
Closed

Filter out empty CloudFront cookies#19
math63 wants to merge 1 commit intopatrickziegler:mainfrom
math63:math63-patch-1

Conversation

@math63
Copy link
Contributor

@math63 math63 commented Feb 4, 2026

When fetching Cloudfront cookies renewal, Strava answer with 2 sets of cookies : one with empty value and Max-age=-1 (to supress old cookies) then the new ones. This script keep the 8 cookies and use probably the empty ones. Resulting a MissingKey error in the web browser. Proposal to filter empty Cloudfront cookies.

@patrickziegler
Copy link
Owner

Hi @math63 , thank you for the contribution! I have just two small requests:

  1. Could you run gofmt -w strava-heatmap-proxy.go to get the formatting right
  2. Remove the long text in the commit description, the title "Filter out empty CloudFront cookies" is sufficient here

You can update your commit with git commit --amend, afterwards I will merge the PR, thanks again!

@patrickziegler patrickziegler added the enhancement New feature or request label Feb 4, 2026
@math63
Copy link
Contributor Author

math63 commented Feb 4, 2026

Hello,

I just performed the 2 points you mentioned.

Best regards,
Mathieu

@patrickziegler
Copy link
Owner

As far as I see, there was no change in the formatting after the update (maybe you didn't git add -A?).

But nevermind, I have quickly done it myself and merged your commit with #20 thanks again!

@math63
Copy link
Contributor Author

math63 commented Feb 5, 2026

I'm not very familiar with git ... Thank you for the update.

@patrickziegler
Copy link
Owner

No problem at all! I appreciate your input 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants