Filter out empty CloudFront cookies#19
Closed
math63 wants to merge 1 commit intopatrickziegler:mainfrom
Closed
Conversation
Owner
|
Hi @math63 , thank you for the contribution! I have just two small requests:
You can update your commit with |
1652dfe to
5710407
Compare
Contributor
Author
|
Hello, I just performed the 2 points you mentioned. Best regards, |
Owner
|
As far as I see, there was no change in the formatting after the update (maybe you didn't But nevermind, I have quickly done it myself and merged your commit with #20 thanks again! |
Contributor
Author
|
I'm not very familiar with git ... Thank you for the update. |
Owner
|
No problem at all! I appreciate your input 👍 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching Cloudfront cookies renewal, Strava answer with 2 sets of cookies : one with empty value and Max-age=-1 (to supress old cookies) then the new ones. This script keep the 8 cookies and use probably the empty ones. Resulting a MissingKey error in the web browser. Proposal to filter empty Cloudfront cookies.