Workaround for TextArea autoResize issue#186
Merged
KevinFCormier merged 1 commit intopatternfly-labs:mainfrom Jan 28, 2025
Merged
Workaround for TextArea autoResize issue#186KevinFCormier merged 1 commit intopatternfly-labs:mainfrom
KevinFCormier merged 1 commit intopatternfly-labs:mainfrom
Conversation
Signed-off-by: Kevin Cormier <kcormier@redhat.com>
KevinFCormier
requested review from
Randy424,
jamestalton and
nitin-dhevar
and removed request for
jamestalton
nitin-dhevar
approved these changes
Jan 28, 2025
Collaborator
nitin-dhevar
left a comment
nitin-dhevar
left a comment
There was a problem hiding this comment.
Text area is not shrinking now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatternFly auto-resize code for the
TextAreais running whilescrollHeightis still 0. This uses a resize observer to ru-run the code again after the initial re-size.