RPC Message Refactor + JSON RPC Error Codes#99
Merged
Conversation
Owner
patvice
commented
Nov 24, 2025
- Replace the bespoke request/response classes with a consolidated RubyLLM::MCP::Native::Messages module that emits JSON-RPC 2.0 envelopes and validates every request/notification against the official 2025‑06‑18 MCP schema (vendored fixture + json_schemer coverage).
- Introduce Native::JsonRpc helpers and an envelope validator so transports (stdio, streamable_http, sse), ResponseHandler, and Result all speak consistent JSON-RPC, surface canonical error codes, and correctly detect notifications vs. responses.
- Expand specs for the new message builders, JSON-RPC validation, transports, and results while deleting the old bespoke request/response objects, ensuring the client now conforms to the MCP spec end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.