-
Notifications
You must be signed in to change notification settings - Fork 13
fix: camera & dark mode revert #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hugo0
wants to merge
4
commits into
dev
Choose a base branch
from
fix/camera-and-dark-fixes
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| 'use client' | ||
|
|
||
| import ActionModal, { type ActionModalButtonProps } from '@/components/Global/ActionModal' | ||
| import { type IconName } from '@/components/Global/Icons/Icon' | ||
| import type { MediaCheckResult } from '@/utils/mediaPermissions.utils' | ||
|
|
||
| interface CameraPermissionWarningModalProps { | ||
| visible: boolean | ||
| onClose: () => void | ||
| onContinueAnyway: () => void | ||
| onOpenInBrowser: () => void | ||
| mediaCheckResult: MediaCheckResult | ||
| } | ||
|
|
||
| /** | ||
| * Modal that warns users when camera/microphone access is likely to fail | ||
| * Offers two options: try anyway in iframe, or open in browser | ||
| */ | ||
| export default function CameraPermissionWarningModal({ | ||
| visible, | ||
| onClose, | ||
| onContinueAnyway, | ||
| onOpenInBrowser, | ||
| mediaCheckResult, | ||
| }: CameraPermissionWarningModalProps) { | ||
| const isError = mediaCheckResult.severity === 'error' | ||
|
|
||
| const getTitle = () => { | ||
| if (isError) { | ||
| return 'Camera or Microphone Required' | ||
| } | ||
| return 'Camera Access May Be Limited' | ||
| } | ||
|
|
||
| const getDescription = () => { | ||
| if (mediaCheckResult.message) { | ||
| return mediaCheckResult.message | ||
| } | ||
| return 'Identity verification requires camera and microphone access. Opening in your browser may provide better results.' | ||
| } | ||
|
|
||
| const ctas: ActionModalButtonProps[] = [ | ||
| { | ||
| text: 'Open in Browser', | ||
| icon: 'arrow-up-right' as IconName, | ||
| iconPosition: 'right', | ||
| onClick: onOpenInBrowser, | ||
| variant: 'purple', | ||
| shadowSize: '4', | ||
| className: 'justify-center', | ||
| }, | ||
| ] | ||
|
|
||
| // Only show "Try Anyway" if it's a warning (not a hard error) | ||
| if (!isError) { | ||
| ctas.push({ | ||
| text: 'Try Anyway', | ||
| onClick: onContinueAnyway, | ||
| variant: 'transparent', | ||
| className: 'underline text-xs md:text-sm !font-normal !transform-none !pt-2 text-grey-1', | ||
| }) | ||
| } | ||
|
|
||
| return ( | ||
| <ActionModal | ||
| visible={visible} | ||
| onClose={onClose} | ||
| title={getTitle()} | ||
| description={getDescription()} | ||
| icon={'alert' as IconName} | ||
| iconContainerClassName={isError ? 'bg-error-1' : 'bg-secondary-1'} | ||
| iconProps={{ className: 'text-white' }} | ||
| ctas={ctas} | ||
| modalPanelClassName="max-w-md" | ||
| contentContainerClassName="text-center" | ||
| ctaClassName="flex-col sm:flex-col" | ||
| /> | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import { useState } from 'react' | ||
| import { checkKycMediaReadiness, type MediaCheckResult } from '@/utils/mediaPermissions.utils' | ||
|
|
||
| interface UseKycCameraCheckOptions { | ||
| onInitiateKyc: () => Promise<{ success: boolean; url?: string; data?: { kycLink?: string } } | undefined> | ||
| onClose: () => void | ||
| saveRedirect?: () => void | ||
| } | ||
|
|
||
| /** | ||
| * Hook to handle camera/microphone pre-flight checks for KYC flows | ||
| * Manages warning modal state and provides handlers for user actions | ||
| */ | ||
| export function useKycCameraCheck({ onInitiateKyc, onClose, saveRedirect }: UseKycCameraCheckOptions) { | ||
| const [showCameraWarning, setShowCameraWarning] = useState(false) | ||
| const [mediaCheckResult, setMediaCheckResult] = useState<MediaCheckResult | null>(null) | ||
| const [kycUrlForBrowser, setKycUrlForBrowser] = useState<string | null>(null) | ||
| const [isChecking, setIsChecking] = useState(false) | ||
|
|
||
| const handleVerifyClick = async () => { | ||
| // Prevent double-clicks | ||
| if (isChecking) return { shouldProceed: false } | ||
| setIsChecking(true) | ||
|
|
||
| try { | ||
| // Pre-flight check: see if camera/mic are available | ||
| const mediaCheck = await checkKycMediaReadiness() | ||
|
|
||
| // Always call KYC initiation once | ||
| const result = await onInitiateKyc() | ||
|
|
||
| // If media is not supported or it's a restricted environment, show warning | ||
| if (result?.success && (!mediaCheck.supported || mediaCheck.severity === 'warning')) { | ||
| setMediaCheckResult(mediaCheck) | ||
| const url = result.url || result.data?.kycLink | ||
| if (url) { | ||
| setKycUrlForBrowser(url) | ||
| setShowCameraWarning(true) | ||
| return { shouldProceed: false } | ||
| } | ||
| } | ||
|
|
||
| return { shouldProceed: result?.success ?? false } | ||
| } finally { | ||
| setIsChecking(false) | ||
| } | ||
| } | ||
|
|
||
| const handleContinueAnyway = () => { | ||
| setShowCameraWarning(false) | ||
| saveRedirect?.() | ||
| onClose() | ||
| } | ||
|
|
||
| const handleOpenInBrowser = () => { | ||
| if (kycUrlForBrowser) { | ||
| // Validate URL is from expected domain for security | ||
| try { | ||
| const url = new URL(kycUrlForBrowser) | ||
| if (url.protocol === 'https:') { | ||
| window.open(kycUrlForBrowser, '_blank') | ||
| } | ||
| } catch { | ||
| console.error('Invalid KYC URL') | ||
| } | ||
| } | ||
| setShowCameraWarning(false) | ||
| onClose() | ||
| } | ||
|
|
||
| return { | ||
| showCameraWarning, | ||
| setShowCameraWarning, | ||
| mediaCheckResult, | ||
| handleVerifyClick, | ||
| handleContinueAnyway, | ||
| handleOpenInBrowser, | ||
| isChecking, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.