Skip to content

Conversation

@saltedlolly
Copy link
Contributor

I have renamed the filenames of the brand logos simply to make them easier to find when working on them - the icon size is now the suffix rather than the prefix. This ensures that when the folder is sorted alphabetically, the three different sizes of icons for each brand appear next to each other.

Also, in the gallery, I added 'RIP' next to the brands that no longer exist. If they have not already, their icons could be removed from PebbleOS.

@lavglaab
Copy link
Collaborator

@hellcp do you have any thoughts here? IIRC, the filenames are organized how they are to make tooling easier (e.g. auto-generating the preview table in the readme).

Also note that since some of these files are referenced in the firmware, the firmware will need to reference the new filenames if this is merged

@saltedlolly
Copy link
Contributor Author

The readme here is not currently generated automatically (or wasn't last time I checked). I was the person who reorganised it manually back in August, updating the gallery to display the missing icons in this repo. (Well, most of them anyway).

Unless there is a very specific reason for the icon filenames having the prefix first it should not make any difference, at least in this repo as I have updated the readme to match. The change just makes the icon files easier to find within the folder. That said, if these svgs are directly referenced in this repo, from PebbleOS, that might affect things.

@hellcp
Copy link
Member

hellcp commented Jan 22, 2026

Tooling wise, it doesn't make a difference if the size is first or last, the only real problem is the spaces in the name

@saltedlolly
Copy link
Contributor Author

I have done some digging and see that these are directly referenced in PebbleOS in resource_map.json

Ref: /resources/normal/base/resource_map.json

I am working on a PR to update them there too, so this could be merged.

@saltedlolly
Copy link
Contributor Author

@lavglaab @hellcp If there are no other blocks, and you are both okay to merge this, I can immediately update the submodule in coredevices/PebbleOS#757

I have some more brand icons I want to help with, but wanted to get this merged first, if possible. Is there anything else you need me to do before that can happen?

@lavglaab lavglaab merged commit 7be3fc0 into pebble-dev:master Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants