-
Notifications
You must be signed in to change notification settings - Fork 6
Fix build on x86_64 Linux #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What environment are you building in? I've had no troubles building the current Looking at the referenced commit, I think I get what this change is doing though - probably makes sense. For the CI failure: just prefix the link with |
It was assumed that mesa provides the necessary X11 includes, but it is not always the case, as it can be configured without x11 support. See: [1]: https://gitlab.com/qemu-project/qemu/-/commit/fbd57c754f32804a63295f70f271d1ef128ee590 Signed-off-by: Mark Penner <mrp@markpenner.space>
OpenSuse Slowroll (uses Tumbleweed packages). Compiler is GCC 14.2.1. I'm not sure what all is relevant, but here's the package info for the |
|
Oh actually I suppose the important thing is I'm running Wayland and I see here: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h?ref_type=heads#L112 there's some includes added if you're running X11, if I'm reading that right. Are you on X11? |
That one's a compile time check, so it probably depends on what flags your distribution provides at compile-time for their package builds. Definitely implies that variation is possible though, so this change is probably a good idea. I've tested it myself and haven't run into any compile or runtime issues - LGTM! Thanks for the PR! |
Address a memory leak bug in the usages of timer_del().
The issue arises from the incorrect use of the ambiguous timer API
timer_del(), which does not free the timer object. The LeakSanitizer
report this issue during fuzzing. The correct API timer_free() freed
the timer object instead.
=================================================================
==2586273==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x55f2afd89879 in calloc /llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:75:3
pebble-dev#1 0x7f443b93ac50 in g_malloc0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5ec50)
pebble-dev#2 0x55f2b053962e in timer_new include/qemu/timer.h:542:12
pebble-dev#3 0x55f2b0514771 in timer_new_us include/qemu/timer.h:582:12
pebble-dev#4 0x55f2b0514288 in lsi_scsi_realize hw/scsi/lsi53c895a.c:2350:24
pebble-dev#5 0x55f2b0452d26 in pci_qdev_realize hw/pci/pci.c:2174:9
Signed-off-by: Zheng Huang <hz1624917200@outlook.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <73cd69f9-ff9b-4cd4-b8aa-265f9d6067b9@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
No description provided.