Skip to content

Conversation

@mrpenner
Copy link

No description provided.

@Sorixelle
Copy link
Member

Sorixelle commented Feb 21, 2025

What environment are you building in? I've had no troubles building the current master on x86_64-linux (granted, in a Nix stdenv, so things might be a little different there) - would be interested to see if I can repro this failure.

Looking at the referenced commit, I think I get what this change is doing though - probably makes sense.

For the CI failure: just prefix the link with [1]: - footnote links don't count for line length checks.

It was assumed that mesa provides the necessary X11 includes,
but it is not always the case, as it can be configured without x11 support.

See:
[1]: https://gitlab.com/qemu-project/qemu/-/commit/fbd57c754f32804a63295f70f271d1ef128ee590

Signed-off-by: Mark Penner <mrp@markpenner.space>
@mrpenner
Copy link
Author

What environment are you building in?

OpenSuse Slowroll (uses Tumbleweed packages). Compiler is GCC 14.2.1. I'm not sure what all is relevant, but here's the package info for the Mesa-libEGL-devel package that provides EGLNativeWindowType on my system.

Information for package Mesa-libEGL-devel:
------------------------------------------
Repository     : update-slowroll
Name           : Mesa-libEGL-devel
Version        : 24.3.4-402.1
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 116.9 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : Mesa-24.3.4-402.1.src
Upstream URL   : https://www.mesa3d.org
Summary        : Development files for the EGL API
Description    : 
    This package contains the development environment required for
    compiling programs against EGL native platform graphics interface
    library. EGL provides a platform-agnostic mechanism for creating
    rendering surfaces for use with other graphics libraries, such as
    OpenGL|ES and OpenVG.

    This package provides the development environment for compiling
    programs against the EGL library.

@mrpenner
Copy link
Author

mrpenner commented Feb 22, 2025

Oh actually I suppose the important thing is I'm running Wayland and I see here: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h?ref_type=heads#L112 there's some includes added if you're running X11, if I'm reading that right. Are you on X11?

@Sorixelle
Copy link
Member

https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h?ref_type=heads#L112

That one's a compile time check, so it probably depends on what flags your distribution provides at compile-time for their package builds. Definitely implies that variation is possible though, so this change is probably a good idea.

I've tested it myself and haven't run into any compile or runtime issues - LGTM! Thanks for the PR!

@Sorixelle Sorixelle merged commit fa2a3df into pebble-dev:master Feb 22, 2025
1 check passed
@mrpenner mrpenner deleted the fix-build branch February 22, 2025 16:15
SteveUcho pushed a commit to SteveUcho/pebble-qemu that referenced this pull request May 7, 2025
Address a memory leak bug in the usages of timer_del().

The issue arises from the incorrect use of the ambiguous timer API
timer_del(), which does not free the timer object. The LeakSanitizer
report this issue during fuzzing. The correct API timer_free() freed
the timer object instead.

=================================================================
==2586273==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x55f2afd89879 in calloc /llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:75:3
    pebble-dev#1 0x7f443b93ac50 in g_malloc0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5ec50)
    pebble-dev#2 0x55f2b053962e in timer_new include/qemu/timer.h:542:12
    pebble-dev#3 0x55f2b0514771 in timer_new_us include/qemu/timer.h:582:12
    pebble-dev#4 0x55f2b0514288 in lsi_scsi_realize hw/scsi/lsi53c895a.c:2350:24
    pebble-dev#5 0x55f2b0452d26 in pci_qdev_realize hw/pci/pci.c:2174:9

Signed-off-by: Zheng Huang <hz1624917200@outlook.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <73cd69f9-ff9b-4cd4-b8aa-265f9d6067b9@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants