feat(locks & db tnx): implement locks mechanism and unify db tnx #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bipin1611
changed the title
…etwork/peer_backend into bipin/fix/race-conditions
This reverts commit 32edd67.
…ckend into bipin/fix/race-conditions
bipin1611
changed the title
vidkazan
approved these changes
Nov 4, 2025
| { | ||
| return $this->db->rollBack(); | ||
| } | ||
| public function isTransactionActive(): bool |
Collaborator
There was a problem hiding this comment.
we can review alternative solutions to this and considering all pros/cons choose the best one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
To avoid concurrency request by a single user, implements locking mechanism.
For Example, when a particular user's request comes in, we will create lock files, which will be unlock and deleted. And a user request sends request at the same, second request will be sent to queues untill we give response.
This method used by PHP's core session management.
At Post & Advertisement creation, we should have to wrap in DB transaction.