Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for selecting timelines and activity instances in the timing management system. It introduces a new schedule timelines feature that allows users to manage timelines with entry/exit conditions and instance references, and enables timings to reference specific activity instances and be associated with schedule timelines.
Key Changes:
- Added schedule timeline entity with CRUD operations and UI
- Enhanced timings to support member_of_timeline field and schedule instance selectors
- Updated UI to replace text inputs with dropdowns for instance selection
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_timings.py | Removed test for timing UID and order index trimming functionality |
| src/usdm/generate_elements.py | Removed unused UID index mapping variables |
| src/soa_builder/web/utils.py | Added helper functions to retrieve scheduled activity instances and schedule timelines |
| src/soa_builder/web/templates/timings.html | Enhanced UI with dropdowns for instance/timeline selection and improved form layout |
| src/soa_builder/web/templates/schedule_timelines.html | New template for schedule timeline management interface |
| src/soa_builder/web/templates/base.html | Added navigation link for schedule timelines |
| src/soa_builder/web/schemas.py | Added member_of_timeline field to timing schemas and new schedule timeline schemas |
| src/soa_builder/web/routers/timings.py | Updated timing endpoints to support member_of_timeline and instance options |
| src/soa_builder/web/routers/schedule_timelines.py | New router implementing full CRUD operations for schedule timelines |
| src/soa_builder/web/routers/instances.py | Renamed return variable from 'row' to 'after' for consistency |
| src/soa_builder/web/migrate_database.py | Added migration to add member_of_timeline column to timing table |
| src/soa_builder/web/initialize_database.py | Added schedule_timelines_audit table initialization |
| src/soa_builder/web/audit.py | Added audit logging function for schedule timeline operations |
| src/soa_builder/web/app.py | Registered schedule timelines router and migration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added timeline selector to timings
Schedule timelines now support selecting entry_id
Timings now support selecting relative to and from ScheduledAcitivityInstance