New features by pendingintent · Pull Request #88 · pendingintent/soa-workbench

pendingintent · 2026-02-08T22:06:04Z

Updates to requirements.txt - removed numpy
Udpates all-or-nothing checks for window Timings

…ng test for window values

…rkbench into ui-features Update

Copilot

Pull request overview

Adds stricter duration/window validation for Timing fields (ISO 8601 / USDM-style), updates UI hints/constraints, and expands router tests to cover the new behavior.

Changes:

Enforce duration format validation for value, window_lower, and window_upper via Pydantic validators.
Enforce “all-or-nothing” rule for the window triplet (window_lower, window_upper, window_label) across API + UI.
Update templates and tests to use duration strings (e.g., P5D) and add validation-focused test cases.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/test_timings.py	Updates expected timing `value`/window fields to duration strings.
tests/test_routers_timings.py	Adds API/UI tests for invalid/valid durations and window all-or-none behavior.
src/soa_builder/web/templates/timings.html	Updates Timing UI fields/order, adds HTML `pattern` constraints and JS all-or-none enforcement.
src/soa_builder/web/templates/instances.html	Renames “Default Condition” label/header to “Next Instance (default condition)”.
src/soa_builder/web/schemas.py	Adds duration regex validation + window all-or-none model validation to Timing schemas.
src/soa_builder/web/routers/timings.py	Converts Pydantic ValidationError into HTTP 400 for UI form endpoints with aggregated messages.

Copilot · 2026-02-08T22:07:57Z

src/soa_builder/web/templates/timings.html

@@ -178,4 +178,32 @@ <h2>Timings for SoA {{ soa_id }}</h2>
  <tr><td colspan="12" style="padding:6px;color:#777;">No timings yet.</td></tr>


The table now has more than 12 columns (additional “Rel To/From” column was added, and columns were rearranged). With colspan="12", the “No timings yet” row won’t span the full table width. Update the colspan to match the current number of <th> columns.

Suggested change

<tr><td colspan="12" style="padding:6px;color:#777;">No timings yet.</td></tr>

<tr><td colspan="16" style="padding:6px;color:#777;">No timings yet.</td></tr>

Copilot · 2026-02-08T22:07:57Z

src/soa_builder/web/schemas.py

+# ISO 8601 duration pattern supporting both standard (-P2D) and USDM (P-2D) conventions
+_ISO8601_DURATION_RE = re.compile(
+    r"^-?P-?(?:(\d+)Y)?(?:(\d+)M)?(?:(\d+)W)?(?:(\d+)D)?(?:T(?:(\d+)H)?(?:(\d+)M)?(?:(\d+)S)?)?$"
+)


This regex accepts durations where T is present but no time components are provided (e.g., P1DT), which is not a valid ISO 8601 duration. Consider adjusting the pattern so that if T is present, at least one of H/M/S must also be present.

Copilot · 2026-02-08T22:07:57Z

src/soa_builder/web/templates/timings.html

    <div style="display:flex;flex-direction:column;gap:2px;">
      <label><strong>Value</strong></label>
-      <input name="value" placeholder="Value (optional)" />
+      <input name="value" placeholder="e.g. P7D (optional)" pattern="-?P-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, P2W, PT8H, -P2D" />


The HTML pattern is looser than the backend validator: it appears to allow inputs like P or PT (no components), which the backend rejects. Tighten the client-side pattern to better match server validation (including disallowing “bare P” / “PT”) so users get immediate feedback and fewer 400/422 errors.

Suggested change

<input name="value" placeholder="e.g. P7D (optional)" pattern="-?P-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, P2W, PT8H, -P2D" />

<input name="value" placeholder="e.g. P7D (optional)" pattern="-?P(?=.*\d)-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, P2W, PT8H, -P2D" />

Copilot · 2026-02-08T22:07:57Z

src/soa_builder/web/templates/timings.html

-      <label><strong>Window Label</strong></label>
-      <input name="window_label" placeholder="Window (optional)" />
+      <label><strong>Window Lower</strong></label>
+      <input name="window_lower" placeholder="e.g. -P2D (optional)" pattern="-?P-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, -P2D, PT8H" />


The HTML pattern is looser than the backend validator: it appears to allow inputs like P or PT (no components), which the backend rejects. Tighten the client-side pattern to better match server validation (including disallowing “bare P” / “PT”) so users get immediate feedback and fewer 400/422 errors.

Copilot · 2026-02-08T22:07:58Z

src/soa_builder/web/templates/timings.html

    <div style="display:flex;flex-direction:column;gap:2px;">
      <label><strong>Window Upper</strong></label>
-      <input name="window_upper" placeholder="+N (optional)" />
+      <input name="window_upper" placeholder="e.g. P3D (optional)" pattern="-?P-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, P3D, PT8H" />


The HTML pattern is looser than the backend validator: it appears to allow inputs like P or PT (no components), which the backend rejects. Tighten the client-side pattern to better match server validation (including disallowing “bare P” / “PT”) so users get immediate feedback and fewer 400/422 errors.

Copilot · 2026-02-08T22:07:58Z

src/soa_builder/web/routers/timings.py

+            member_of_timeline=member_of_timeline,
+        )
+    except ValidationError as exc:
+        msgs = "; ".join(e["msg"] for e in exc.errors())


Aggregating only e["msg"] drops the field context, making UI errors harder to act on (e.g., users can’t tell whether window_upper vs value failed). Include the error location (typically e["loc"]) in the message formatting so the response clearly identifies which field(s) are invalid.

Suggested change

msgs = "; ".join(e["msg"] for e in exc.errors())

msgs = "; ".join(

(

f"{'.'.join(str(p) for p in e.get('loc', []))}: {e.get('msg')}"

if e.get("loc")

else str(e.get("msg"))

)

for e in exc.errors()

)

Copilot · 2026-02-08T22:07:58Z

tests/test_routers_timings.py

+
+
+def test_window_accepts_valid_iso8601_durations():
+    """Test that various valid ISO 8601 durations are accepted."""


The implementation and tests accept both standard ISO 8601 negatives (-P2D) and a USDM-style form (P-2D). Calling these values “ISO 8601” in docstrings (and UI titles) is misleading. Consider updating wording to something like “ISO 8601 (plus USDM-style P-… durations)” to match actual accepted inputs.

Suggested change

"""Test that various valid ISO 8601 durations are accepted."""

"""Test that various valid ISO 8601 durations (plus USDM-style `P-…` durations) are accepted."""

pendingintent · 2026-02-08T22:22:31Z

The checks are reporting incorrectly so closing this PR

pendingintent added 10 commits February 6, 2026 11:23

Ordered timing fields in logical way; added hover help text

5693cd1

Changed Default Condition header

a84ff8d

Rearranged headers to make timings more intuitive

18e6102

Added ISO validation rules for windows, value as well as all-or-nothi…

ef1a7ca

…ng test for window values

Removed numpy dependency

ee05f7e

Merge branch 'master' into ui-features

564fab7

Ensure window values are all-or-nothing

f52d47c

Merge branch 'ui-features' of https://github.com/pendingintent/soa-wo…

1511c1e

…rkbench into ui-features Update

Updated requirements.txt

c50a8f1

Updated requirements.txt

80cedf0

Copilot AI review requested due to automatic review settings February 8, 2026 22:06

pendingintent self-assigned this Feb 8, 2026

pendingintent added the enhancement New feature or request label Feb 8, 2026

pendingintent added this to the v1.0 milestone Feb 8, 2026

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Updated to use python 3.13

aa57741

pendingintent closed this Feb 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New features#88

New features#88
pendingintent wants to merge 11 commits intomasterfrom
new-features

pendingintent commented Feb 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

pendingintent commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -178,4 +178,32 @@ <h2>Timings for SoA {{ soa_id }}</h2>
		<tr><td colspan="12" style="padding:6px;color:#777;">No timings yet.</td></tr>

	<tr><td colspan="12" style="padding:6px;color:#777;">No timings yet.</td></tr>
	<tr><td colspan="16" style="padding:6px;color:#777;">No timings yet.</td></tr>

	<input name="value" placeholder="e.g. P7D (optional)" pattern="-?P-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, P2W, PT8H, -P2D" />
	<input name="value" placeholder="e.g. P7D (optional)" pattern="-?P(?=.*\d)-?(\d+Y)?(\d+M)?(\d+W)?(\d+D)?(T(\d+H)?(\d+M)?(\d+S)?)?" title="ISO 8601 duration, e.g. P1D, P2W, PT8H, -P2D" />



		def test_window_accepts_valid_iso8601_durations():
		"""Test that various valid ISO 8601 durations are accepted."""

Conversation

pendingintent commented Feb 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

pendingintent commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants