microcom.c: Call cleanup routines only once #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
Contributor
Author
Repeated call to ios->exit(ios); was observed as used after free using asan. Only call it once: In the exit handler. Always call the exit handler and check there whether listenonly is set and there skip resetting the terminal if so. Do not reset the terminal elsewhere. Do not call the exit handler from the quit command, just call exit, invoking the signal handler too. Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
jonrebm
force-pushed
the
cleaup-routines
branch
from
b07e1fe to
3efc952
Compare
|
|
||
| ios->exit(ios); | ||
| tcsetattr(STDIN_FILENO, TCSANOW, &sots); | ||
| if (listenonly) |
Member
There was a problem hiding this comment.
This should be if (!listenonly) right? The terminal is configured for !listenonly so it should be restored in that case as well.
| { | ||
| fflush(NULL); | ||
| microcom_exit(0); | ||
| exit(0); |
Member
There was a problem hiding this comment.
Are you sure this is correct? You're commit message implies that exit(0) will somehow call microcom_exit() but when I tested this PR, that is not what happened.
Specifically exiting is not printed when stopping microcom with the quit command.
Contributor
Author
|
Thank you @michaelolbrich. Seems I need to run another round of testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeated call to ios->exit(ios); was observed as used after free using asan. Only call it once: In the exit handler.
Always call the exit handler and check there whether listenonly is set and there skip resetting the terminal if so.
Do not reset the terminal elsewhere.
Do not call the exit handler from the quit command, call exit instead.