fsl_imx: Drop extension allowing to boot ancient i.MX CPUs via UART #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oldest i.MX CPU that I know is still in active use is i.MX25 launched in 2009. That one already uses USB for recovery booting. I think UART booting is only usable for the older i.MX1. So I guess removing this code doesn't hurt anyone. Compiling the source results in several warnings à la: commands_fsl_imx.c: In function ‘fsl_sniff’: commands_fsl_imx.c:597:17: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 597 | read(ios->fd, &cmd, 1); | ^~~~~~~~~~~~~~~~~~~~~~ which are fixed by removing this code 😎. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oldest i.MX CPU that I know is still in active use is i.MX25 launched in 2009. That one already uses USB for recovery booting. I think UART booting is only usable for the older i.MX1.
So I guess removing this code doesn't hurt anyone.
Compiling the source results in several warnings à la:
which are fixed by removing this code 😎.