Merged
Conversation
…sample table to filter out ph_id, and set default schema dropdown in new pep modal to databio/pep-2.1.0
# Conflicts: # pephub/_version.py
bring in task def changes
…cle_stage, maintainers, contributors, release_notes
Schemas 2.0
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the release to 0.15.0 and introduces new schema functionality including records, versions, and tags. Key changes include a new key-value input component, extensive updates to the schemas API with modified payloads and endpoints for schema versions, and adjustments to various namespace and project routes across both the API and UI.
Reviewed Changes
Copilot reviewed 58 out of 62 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/components/forms/components/key-value-input.tsx | New component enabling tag-based key/value input. |
| web/src/api/schemas.ts | Updates to schema types and endpoints (including schema versioning) with updated query parameters and payload structure. |
| pephub/helpers.py | Addition of a new function to download JSON content. |
| pephub/routers/api/v1/namespace.py, pephub/routers/models.py, web/src/api/namespace.ts | Adjustments to namespace information routes and modeling, aligning with new schema functionality. |
| pephub/dependencies.py, pephub/routers/api/v1/project.py, pephub/main.py | Various routing, dependency, and version updates across the codebase. |
| web/src/components/forms/components/schemas-databio-dropdown.tsx, combined-error-message.tsx, namespace-grid.tsx, namespace-long-row.tsx | Modifications to utilize the new schema naming conventions and improve UI consistency. |
| .github/workflows/black.yml | Workflow update to newer action versions. |
| pephub/_version.py | Version bump to 0.15.0_dev0. |
Files not reviewed (4)
- deployment/task_defs/dev.json: Language not supported
- deployment/task_defs/primary.json: Language not supported
- launch_docker.sh: Language not supported
- requirements/requirements-all.txt: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deploying pephub-ui with
|
| Latest commit: |
586555c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3aa1e995.pephub.pages.dev |
| Branch Preview URL: | https://dev.pephub.pages.dev |
requirements/requirements-all.txt
Outdated
| pepdbagent>=0.11.1 | ||
| # pepdbagent @ git+https://github.com/pepkit/pepdbagent.git@schams2.0#egg=pepdbagent | ||
| #pepdbagent>=0.11.1 | ||
| pepdbagent @ git+https://github.com/pepkit/pepdbagent.git@dev#egg=pepdbagent |
donaldcampbelljr
approved these changes
Mar 26, 2025
donaldcampbelljr
left a comment
donaldcampbelljr
left a comment
There was a problem hiding this comment.
Python looks good. Did not review .ts files.
Address sample table issues related to copying and pasting ph_id col
nleroy917
approved these changes
Mar 27, 2025
Member
nleroy917
left a comment
nleroy917
left a comment
There was a problem hiding this comment.
If it works.. I approve. I didnt have time to go through his with a fine-toothed comb, however since there were so many changes
pephub/_version.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = "0.14.4" | |||
| __version__ = "0.15.0_dev0" | |||
Member
There was a problem hiding this comment.
We are merging to master, should we change this?
Comment on lines
+192
to
+200
| formData.append('schema_name', schemaName || ''); | ||
| formData.append('description', description || ''); | ||
| formData.append('private', isPrivate.toString()); | ||
| formData.append('contributors', contributors || ''); | ||
| formData.append('maintainers', maintainers || ''); | ||
| formData.append('tags', tags ? JSON.stringify(tags) : '{}'); | ||
| formData.append('version', version || ''); | ||
| formData.append('release_notes', releaseNotes || ''); | ||
| formData.append('lifecycle_stage', lifecycleStage || ''); |
Member
There was a problem hiding this comment.
I know that i started this trend, but is it ok if we append empty strings?
Member
There was a problem hiding this comment.
Feels like prettier needs run on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
TODO: