Update CI so it runs correctly for Ruby 2.3 - Ruby head#150
Open
petergoldstein wants to merge 1 commit intoperfectline:masterfrom
Open
Update CI so it runs correctly for Ruby 2.3 - Ruby head#150petergoldstein wants to merge 1 commit intoperfectline:masterfrom
petergoldstein wants to merge 1 commit intoperfectline:masterfrom
Conversation
Member
|
why are you dropping public_suffix and jewellery? |
Author
|
I didn't drop I dropped |
jaynetics
added a commit
to jaynetics/validates_url
that referenced
this pull request
Oct 22, 2024
fixes perfectline#122. I could only run the specs by removing Gemfile.lock and would recommend perfectline#150 to be merged before this PR. Several examples were red with NoMethodErrors before I made any changes. I had to add the `value && ` to fix that. The example `does not allow a url with only a scheme` was also red. I had to add the `host.empty?` check to fix that one.
kritik
pushed a commit
that referenced
this pull request
Oct 22, 2024
fixes #122. I could only run the specs by removing Gemfile.lock and would recommend #150 to be merged before this PR. Several examples were red with NoMethodErrors before I made any changes. I had to add the `value && ` to fix that. The example `does not allow a url with only a scheme` was also red. I had to add the `host.empty?` check to fix that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR required some modernization of the gemspec, changes to the CI file, and a minor code change. Everything runs green on my fork.
Also updates checkout action to v3, allowing it to run (v2 and earlier no longer run properly)