Skip to content

Use ESLint, Prettier for code linting+formatting#188

Merged
perliedman merged 2 commits intoperliedman:masterfrom
simon04:prettier
Jan 9, 2018
Merged

Use ESLint, Prettier for code linting+formatting#188
perliedman merged 2 commits intoperliedman:masterfrom
simon04:prettier

Conversation

@simon04
Copy link
Collaborator

@simon04 simon04 commented Jan 8, 2018

npm run test finds issues w.r.t. ESLint and/or Prettier config

@perliedman
Copy link
Owner

Nice, I'm in favor of cleaning up the current mess in one big swoop (and then keep it clean with prettier) - but I guess we should coordinate when to merge this, so we don't accidentally make other valuable PRs invalid.

As it is now, this already has conflict, but I guess they should be easy resolve by rebasing.

@simon04
Copy link
Collaborator Author

simon04 commented Jan 9, 2018

I rebased onto master. Let's merge it right away, I'll take care of my single other open PR #189 since that might need some discussion.

@perliedman perliedman merged commit 9bb2365 into perliedman:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants