Use ESLint, Prettier for code linting+formatting#188
Merged
perliedman merged 2 commits intoperliedman:masterfrom Jan 9, 2018
Merged
Use ESLint, Prettier for code linting+formatting#188perliedman merged 2 commits intoperliedman:masterfrom
perliedman merged 2 commits intoperliedman:masterfrom
Conversation
Owner
|
Nice, I'm in favor of cleaning up the current mess in one big swoop (and then keep it clean with prettier) - but I guess we should coordinate when to merge this, so we don't accidentally make other valuable PRs invalid. As it is now, this already has conflict, but I guess they should be easy resolve by rebasing. |
Collaborator
Author
|
I rebased onto master. Let's merge it right away, I'll take care of my single other open PR #189 since that might need some discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run testfinds issues w.r.t. ESLint and/or Prettier config