Substantially improve Photon results with map-derived parameters#339
Merged
simon04 merged 1 commit intoperliedman:masterfrom Dec 26, 2024
Merged
Substantially improve Photon results with map-derived parameters#339simon04 merged 1 commit intoperliedman:masterfrom
simon04 merged 1 commit intoperliedman:masterfrom
Conversation
Repository owner
deleted a comment from
Simic69
Dec 15, 2024
Contributor
|
Hi. Any comment about this PR ? It looks interesting ;-) |
simon04
force-pushed
the
photon-params
branch
from
cc75b5a to
950dd75
Compare
The Photon geocoder returns poor results unless the center point and zoom of the map are included as query parameters.
simon04
force-pushed
the
photon-params
branch
from
950dd75 to
4a363d0
Compare
simon04
approved these changes
Dec 26, 2024
Collaborator
simon04
left a comment
simon04
left a comment
There was a problem hiding this comment.
Thank you! I've reworked this patch for the new promise-based API. Before, the context was meant to be used as this context for the callback. I'll fix the typing error in a follow-up commit.
simon04
added a commit
that referenced
this pull request
Dec 26, 2024
simon04
added a commit
that referenced
this pull request
Dec 26, 2024
Contributor
|
Thanks :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Photon geocoder returns poor, jarring results unless the center point and zoom of the map are included as query parameters. Now these data are included. They are passed via the
contextargument, so other geocoders with similar optional parameters may be improved as well.