feat: Added Ingress SecurityContext and ServiceAccount#65
Open
tomassatka wants to merge 1 commit intopermitio:masterfrom
Open
feat: Added Ingress SecurityContext and ServiceAccount#65tomassatka wants to merge 1 commit intopermitio:masterfrom
tomassatka wants to merge 1 commit intopermitio:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Please add:
service:
port: 7000
To avoid the following error during Helm install:
Error: INSTALLATION FAILED: template: opal/templates/ingress-client.yaml:40:30: executing "opal/templates/ingress-client.yaml" at <$.Values.service.port>: nil pointer evaluating interface {}.port
Author
There was a problem hiding this comment.
Yes good catch. Sorry for that. I corrected it and point to client.opaPort
tomassatka
force-pushed
the
master
branch
6 times, most recently
from
3eeb5d5 to
139852c
Compare
Signed-off-by: tomassatka <satka.tomas@gmail.com>
|
Hi, is there any follow-up to this PR? Having an ingress as well would be useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made few improvements