Skip to content

GEOIN-142 Made change events from TerraDraw throttleable #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larsabrasha wants to merge 4 commits into
base: feature/GEOIN-80
Choose a base branch
from
+32 −7
Open

GEOIN-142 Made change events from TerraDraw throttleable #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e37862c
GEOIN-142 Using a throttle to limit terra draw events
larsabrasha Jan 29, 2026
92b857c
GEOIN-142 Made the throttle time configurable
larsabrasha Jan 29, 2026
c71682f
GEOIN-116 Fix of client exception when clicking on the map
larsabrasha Feb 5, 2026
3a8bd6b
Merge pull request #20 from peroper/feature/GEOIN-116
jensahre Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Community.Blazor.MapLibre/MapLibre.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,13 +294,13 @@ public async Task<Listener> AddTerraDrawDeleteListener<T>(Action<T> handler)
return new Listener(callback);
}

public async Task<Listener> AddTerraDrawChangeListener<T>(Action<T> handler)
public async Task<Listener> AddTerraDrawChangeListener<T>(Action<T> handler, int throttleTime)
{
var callback = new CallbackHandler(_jsModule, "change", handler, typeof(T));
var reference = DotNetObjectReference.Create(callback);
_references.TryAdd(Guid.NewGuid(), reference);

await _jsModule.InvokeVoidAsync("onTerraDrawChange", MapId, reference);
await _jsModule.InvokeVoidAsync("onTerraDrawChange", MapId, reference, throttleTime);

return new Listener(callback);
}
Expand Down
32 changes: 28 additions & 4 deletions Community.Blazor.MapLibre/MapLibre.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,18 +261,42 @@ export function onTerraDrawDelete(container, dotnetReference) {
});
}

export function onTerraDrawChange(container, dotnetReference) {
export function onTerraDrawChange(container, dotnetReference, throttleTime = 100) {
const draw = drawControls[container];

const throttledInvoke = throttle(() => {
const features = draw.getSnapshot();
const featuresAsJson = JSON.stringify(features);
dotnetReference.invokeMethodAsync('Invoke', featuresAsJson);
}, throttleTime);

draw.on('change', (ids, type) => {
if (type === 'create' || type === 'update' || type === 'delete') {
const features = draw.getSnapshot();
const featuresAsJson = JSON.stringify(features);
dotnetReference.invokeMethodAsync('Invoke', featuresAsJson);
throttledInvoke();
}
});
}

function throttle(func, intervalInMs) {
let lastFunc;
let lastRan;

return function(...args) {
if (!lastRan) {
func.apply(this, args);
lastRan = Date.now();
} else {
clearTimeout(lastFunc);
lastFunc = setTimeout(() => {
if ((Date.now() - lastRan) >= intervalInMs) {
func.apply(this, args);
lastRan = Date.now();
}
}, intervalInMs - (Date.now() - lastRan));
}
}
}

/**
* Adds a scale control to the given map container.
*
Expand Down
1 change: 1 addition & 0 deletions Community.Blazor.MapLibre/Models/Feature/IFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Community.Blazor.MapLibre.Models.Feature;

[JsonPolymorphic(TypeDiscriminatorPropertyName = "$type")]
[JsonDerivedType(typeof(FeatureCollection))]
[JsonDerivedType(typeof(FeatureFeature))]
public interface IFeature
Expand Down
2 changes: 1 addition & 1 deletion Community.Blazor.MapLibre/Models/Feature/IGeometry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Community.Blazor.MapLibre.Models.Feature;

[JsonPolymorphic(TypeDiscriminatorPropertyName = "type")]
[JsonPolymorphic(TypeDiscriminatorPropertyName = "$type")]
[JsonDerivedType(typeof(LineGeometry), typeDiscriminator: "LineString")]
[JsonDerivedType(typeof(MultiLineGeometry), typeDiscriminator: "MultiLineString")]
[JsonDerivedType(typeof(MultiPointGeometry), typeDiscriminator: "MultiPoint")]
Expand Down