Fixing some issues from validation + some additions#3
Open
adamml wants to merge 46 commits intopeterataylor:masterfrom
Open
Fixing some issues from validation + some additions#3adamml wants to merge 46 commits intopeterataylor:masterfrom
adamml wants to merge 46 commits intopeterataylor:masterfrom
Conversation
Initial commit of the Ocean Acidification fork of om-json. Intention is to push this back to the master with a pull request when ready.
No requires "id" and "methodology"
Removed the peterataylor repository references to fix the issues faced by XMLSpy and Oasis. Will need to revert this prior to the pull request being issued and will log as an issue.
Moved the Context.json file to ./json-ld for file structuring clarity
- MonitoringFeature contain an incorrect link to geometryObject. This is
in Geometry.json, not Common.json
- MonitoringFeature lists id as required, but there is no definition
provided (does this duplicate the id definition in SamplingCollection,
or do we pull the definition out into Common and reference it from there
in both SamplingCollection and MonitoringFeature…
- SamplingCollection contains type class which is of type “enum”:
"type": {
"title": "type",
"description": "Identifies the type of object",
"type": "enum"
},
he reference example file filename contains a type
(Reference_Examle.json instead of Reference_Example.json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In using the OM-JSON repo for soem work with the Ocean Acidification project we ran into some validation issues (using XMLSpy which seems pretty good for JSONSchema validation too),
Bug fixes included.
Also, we added properties for DOI and @context to Common.json. Use of @context has been added to all Schema.
There's an additional call-out in Obserrvation.json for the Ocean Acidification work which points to my repo,