Merged
Conversation
1. Missing `#include <algorithm>`
```
In file included from C:\Users\Admin\AppData\Local\Temp\.xmake\250616\_A06D4C99BAEB47BF9D52FB3EAF91C354.cpp:2:
In file included from C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector.hpp:8:
In file included from C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/Arithmetic.hpp:8:
C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Common/Functional.hpp:126:15: error: no member named 'max' in namespace 'std'
return std::max(lhs, rhs);
~~~~~^
C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Common/Functional.hpp:155:15: error: no member named 'min' in namespace 'std'; did you mean 'fmin'?
return std::min(lhs, rhs);
~~~~~^
```
…oper member access syntax
```
In file included from C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector.hpp:11:
In file included from C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Matrix/../Vector/Math.hpp:314:
In file included from C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Matrix/Math.hpp:440:
C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Matrix/../Decompositions/DecomposeLU.hpp:129:33: error: member reference base type 'DecompositionLU' is not a structure or union
return DecompositionLU{ L, U }.Solve(Permute(b));
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Matrix/../Decompositions/DecomposeLU.hpp:132:48: error: member reference base type 'DecompositionLU' is not a structure or union
return InversePermute(DecompositionLU{ L, U }.Solve(b));
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
2 errors generated.
```
…ary minus to the temporary variable instead of directly to Vector constructor.
```
In file included from C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector.hpp:11:
C:\Users\Admin\AppData\Local\.xmake\packages\m\mathter\v2.0.0\4428b8c9c4454261be12cd053ca4a35b\include\Mathter/Vector/../Matrix/../Vector/Math.hpp:379:45: error: invalid argument type 'Vector' to unary expression
return FMTA(Vector(a.yzx), Vector(b.zxy), -Vector(a.zxy), Vector(b.yzx));
^~~~~~~~~~~~~~
1 error generated.
```
luadebug
added a commit
to luadebug/xmake-repo
that referenced
this pull request
Jun 16, 2025
waruqi
pushed a commit
to xmake-io/xmake-repo
that referenced
this pull request
Jun 17, 2025
* mathter: update to v2.0.0 * Validate android NDK r22 build fix for PR petiaccja/Mathter#55 * Update packages/m/mathter/xmake.lua Co-authored-by: Péter Kardos <kardospeter1994@hotmail.com> --------- Co-authored-by: Péter Kardos <kardospeter1994@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix android NDK r22 build.
#include <algorithm>