Ignore decodeURIComponent errors in auth parsing + README touchups#18
Open
allenluce wants to merge 2 commits intopetkaantonov:masterfrom
Open
Ignore decodeURIComponent errors in auth parsing + README touchups#18allenluce wants to merge 2 commits intopetkaantonov:masterfrom
allenluce wants to merge 2 commits intopetkaantonov:masterfrom
Conversation
added 2 commits
July 3, 2018 12:09
For when the URL's auth carries a percent sign not intended to escape: http://first%last@example.com
Fixing headers + grammar + spelling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For when the URL's auth carries a percent sign not intended to escape:
http://first%last@example.comFix headers in the README. Also give grammar and spelling a once-over.
The reformatting on line 755 in
src/urlparser.jsis to shut lint up.