Implement bulk key fetching and deleting for large queue#44
Open
shioshiota wants to merge 4 commits intomasterfrom
Open
Implement bulk key fetching and deleting for large queue#44shioshiota wants to merge 4 commits intomasterfrom
shioshiota wants to merge 4 commits intomasterfrom
Conversation
7b3b989 to
d3e5936
Compare
d3e5936 to
21b33e1
Compare
everpeace
suggested changes
Sep 7, 2021
Contributor
everpeace
left a comment
There was a problem hiding this comment.
I left several comments. PTAL.
| Client: client, | ||
| Backoff: backoffConfig, | ||
| ChunkSizeInGet: 1000, | ||
| ChunkSizeInDelete: 1000, |
Contributor
There was a problem hiding this comment.
Would you mind adding tests for chunked deletion (large queue)??
Contributor
Author
There was a problem hiding this comment.
I added a test for chunked deletion.
f2b8503
Co-authored-by: Shingo Omura <everpeace@gmail.com>
e379032 to
f2b8503
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to reduce redis load by delete-queue command when the queue has a large number of tasks.
*a large number is about 10^6
I implemented following improvements:
fixes #28