-
Notifications
You must be signed in to change notification settings - Fork 5
Login prompt wrapper and DeGiro constructor function #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added to extend login function to dynamically ask password/totp from user, hiding password while typing. In this way, password doesn't have to be included in .py scripts.
Constructor enbales an option to automatically login when creating DeGiro instance. (using login_prompt)
Updated examples to include some use cases of constructor and login_prompt.
Jakub-CZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embeding login into __init__ seems unnecessary (saving just one line of code), perhaps even a bit confusing. But as long as it doesn't break anything, no harm done.
|
The way I dealt with password is that I import it (and other "secret" things) from It's very easy to implement, and I think it gives me the right balance of security and convenience, assuming my PCs are secure and trusted. Some other options are:
|
Co-authored-by: Jakub Loucký <jakub.loucky@outlook.cz>
Co-authored-by: Jakub Loucký <jakub.loucky@outlook.cz>
Co-authored-by: Jakub Loucký <jakub.loucky@outlook.cz>
Thanks for the feedback! The ways you propose are more practical. I will integrate them to my pipelines. |
I had an idea to create a function that prompts for password (hiding it while typing), because I didn't like the idea to include my passwords in all .py scripts I used.
Added functions to _init_.py
Notes
Some use cases examples can be seen in examples.py which I've also updated.
Your feedback will be appreciated!