Skip to content

Fix: validate host ID uniqueness in get-join-options endpoint #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moizpgedge merged 5 commits into from
Dec 15, 2025
Merged

Fix: validate host ID uniqueness in get-join-options endpoint #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a945b3
Validate host ID uniqueness in get-join-options endpoint
moizpgedge Dec 8, 2025
06eabc9
Simplify validateHostIDUniqueness error handling
moizpgedge Dec 10, 2025
2da1249
Add host ID uniqueness validation to join-cluster endpoint
moizpgedge Dec 12, 2025
e5e9833
Fix error handling in host ID uniqueness validation
moizpgedge Dec 15, 2025
64cecf9
Regenerate API files with latest design changes
moizpgedge Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/apiv1/design/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ var _ = g.Service("control-plane", func() {
g.Payload(ClusterJoinToken)
g.Error("cluster_already_initialized")
g.Error("invalid_join_token")
g.Error("invalid_input")

g.HTTP(func() {
g.POST("/v1/cluster/join")
Expand Down Expand Up @@ -117,6 +118,7 @@ var _ = g.Service("control-plane", func() {
g.Payload(ClusterJoinRequest)
g.Error("cluster_not_initialized")
g.Error("invalid_join_token")
g.Error("invalid_input")
Copy link
Member

@jason-lynch jason-lynch Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add this error to the join-cluster endpoint below and re-run make -C api generate? This error is required in both places so that we return the correct error to the client.


g.HTTP(func() {
g.POST("/v1/internal/cluster/join-options")
Expand Down
2 changes: 2 additions & 0 deletions api/apiv1/gen/control_plane/client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions api/apiv1/gen/control_plane/service.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions api/apiv1/gen/http/control_plane/client/encode_decode.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

66 changes: 66 additions & 0 deletions api/apiv1/gen/http/control_plane/client/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions api/apiv1/gen/http/control_plane/server/encode_decode.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 40 additions & 0 deletions api/apiv1/gen/http/control_plane/server/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions api/apiv1/gen/http/openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions api/apiv1/gen/http/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions api/apiv1/gen/http/openapi3.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions api/apiv1/gen/http/openapi3.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading