Backup new #10
Open
Backup new #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed AZURE_KEY and AZURE_KEY_TYPE build-time ARGs - Azure configuration now only done at runtime via environment variables - Fixes Docker BuildKit security warnings about sensitive data in ARGs
# Conflicts: # src/config/parse.c
When a dependency is invalid and no default value exists, the code was not checking if the option should be required. This caused incorrect OptionRequiredError messages where cloud storage options (like repo1-gcs-bucket) were being required even when the repo type was not set to GCS. The fix adds the required option check in the else branch (when dependency is invalid) and ensures that options are not required when dependencies are invalid, matching the behavior in the valid dependency branch. This resolves test failures in: - config/load, config/parse, config/exec, config/protocol - command/backup, command/archive-push - integration tests - documentation build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read Submitting a Pull Request before submitting.