-
Notifications
You must be signed in to change notification settings - Fork 5
476 enhancement add mean plots with correct blq rule #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KOBANAK
wants to merge
21
commits into
main
Choose a base branch
from
476-enhancement-add-mean-plots-with-correct-blq-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
476 enhancement add mean plots with correct blq rule #555
KOBANAK
wants to merge
21
commits into
main
from
476-enhancement-add-mean-plots-with-correct-blq-rule
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nhancement-add-mean-plots-with-correct-blq-rule
4 tasks
Collaborator
…nhancement-add-mean-plots-with-correct-blq-rule
m-kolomanski
requested changes
Jul 23, 2025
Collaborator
|
Hey @KOBANAK I need more context to understand the original issue, what do you mean with
|
Collaborator
Author
Shaakon35
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #476
Description
Create mean plots for both LOG and LIN scale
Definition of Done
The requirements for the feature to be complete:
How to Test:
Try both main dummy data set (with no AVALC) and the example-duplicates-ADNCA in test folder, which contains AVALC. In this file, I have added
BLQvalues for all NFRLT = 4 in the first dose, so these should be removed in the TLG mean plot.Check that the mean linear plot renders and that the options are working as expected.
Contributor checklist
Notes to reviewer
@js3110 taken over December 23
/!\ On the meanplots, points from a same group were not linked to each other, geom_line within g_lineplot does not seem to work well when plotly obejct is created, to solve this I have just explicitly added a
geom_linecall, but not sure if this is the best approach!Test the BLQ handling in mean plots with test-duplicate-ADNCA.csv