feat: add Associated Persons (AP) domain support#133
Open
ankonyeni wants to merge 3 commits intopharmaverse:mainfrom
Open
feat: add Associated Persons (AP) domain support#133ankonyeni wants to merge 3 commits intopharmaverse:mainfrom
ankonyeni wants to merge 3 commits intopharmaverse:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 82.19% 83.99% +1.79%
==========================================
Files 7 7
Lines 691 831 +140
==========================================
+ Hits 568 698 +130
- Misses 123 133 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Associated Persons (AP) domain support to
combine_suppandbuild_qnamChanges
combine_suppAPIDorUSUBJIDand resolvesid_vardynamicallyAPIDandUSUBJIDare present in the supp datasetAPIDnorUSUBJIDare present in the supp datasetAPIDandUSUBJIDare present in the parent datasetSTUDYID,DOMAIN, and the resolvedid_varare present in the parent datasetcombine_supp_joinbykey resolution to includeAPIDalongsideUSUBJIDbuild_qnamAPIDorUSUBJIDand resolvesid_vardynamicallyAPIDandUSUBJIDare present in the datasetAPIDnorUSUBJIDare present in the datasetselect,distinct, and output column to use resolvedid_varid_varTests
New tests added for both
combine_suppandbuild_qnamcovering:USUBJIDandAPIDdomainsIDVARcolumn existence validationNAIDVARhandling for subject-level records