Skip to content

Update error message to reflect that token is retrieved from keytar #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szhu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update error message to reflect that token is retrieved from keytar #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/gh-client.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,11 @@ module.exports = new class GitHubClient
# yield [] so consumers still run
return []
catch error
console.error(error)

atom.notifications.addError 'Error fetching Pull Request data from GitHub',
dismissable: true
detail: 'Make sure you are connected to the internet and if this is a private repository then you will need to create a token from https://github.com/settings/tokens and provide it to the pull-requests plugin settings'
detail: """Make sure you are connected to the internet. If this is a private repository then you will need to create a token from https://github.com/settings/tokens and add it to your system keychain with service name "#{KEYTAR_SERVICE_NAME}" and account name "#{KEYTAR_ACCOUNT_NAME}"."""

# tokenDialog = new Dialog({
# defaultValue: keytar.getPassword(KEYTAR_SERVICE_NAME, KEYTAR_ACCOUNT_NAME)
Expand Down