Adds support for setting additional client args.#45
Open
dylan-stark wants to merge 1 commit intophilschmid:mainfrom
Open
Adds support for setting additional client args.#45dylan-stark wants to merge 1 commit intophilschmid:mainfrom
dylan-stark wants to merge 1 commit intophilschmid:mainfrom
Conversation
ghost
mentioned this pull request
rodrigomasiniai
approved these changes
Jan 23, 2024
rodrigomasiniai
approved these changes
Jan 23, 2024
rodrigomasiniai
left a comment
rodrigomasiniai
left a comment
There was a problem hiding this comment.
The following provides client args capability that was missing
omkar-334
approved these changes
Jul 19, 2024
omkar-334
left a comment
omkar-334
left a comment
There was a problem hiding this comment.
this added functionality would be useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for setting additional client args to address issue #44.
Essentially, I added a module-level
client_argsdictionary, similar tohuggingface.api_keyand.prompt_builder. A user can put headers, cookies, etc., in there. And the key-value pairs will get unpacked at call-time as additional keyword args.Note that I left the (implicit)
modelandtokenargs untouched. Perhaps it makes sense to do a little work to check whether those are inclient_argsahead of the call.