Battery voltage display and holeshot timing #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for updated restrictions in mobile browsers, where SpeechSynthesis.speak without user activation is not allowed anymore More about changes browser changes: https://chromestatus.com/feature/5687444770914304
Owner
|
I merged the voice fix and now there is a conflict. Once fixed it can be merged. Thank you for your contribution! |
…hobosLT into holeshot-and-battery
Contributor
Author
|
It didn't let me resolve the conflict in the web editor, so I had to stumble my way through rebasing and the commit history doesn't look great, but it should be done and ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Stop Racenow resets race internally, allowing for starting a new race with a new holeshot without clearing the display of previous laps/racesNote that I previously created #20 but deleted that pull request and made this one without the VSCode formatting commit to prevent future merge conflicts.