Add OLED display support option for ESP32 OLED Boards #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h OLED display and 18650 battery holder
phobos-
reviewed
Oct 14, 2024
| #else | ||
|
|
||
| #define PIN_LED 21 | ||
| #define PIN_LED 16 //was 21 |
Owner
There was a problem hiding this comment.
could you add a separate target that supports the OLED display instead of modifying an existing one? Or add guards like :
#ifdef ESP32_OLED
#define PIN_LED 16 //was 21
#else
#define PIN_LED 21
#endif
| rx.init(); | ||
| buzzer.init(PIN_BUZZER, BUZZER_INVERTED); | ||
| led.init(PIN_LED, false); | ||
| led.init(PIN_LED, true); //was false |
Contributor
|
Also would be nice to move the new target to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OLED display support option for boards like TTGO ESP32 module with OLED display and 18650 battery holder.
See, e.g., https://www.areresearch.net/2018/01/how-to-use-ttgo-esp32-module-with-oled.html
The display shows:
the WiFi SSID
Battery Voltage
Frequency Name
Frequency GHz
Pilot Name
Last Lap Time
This pull request also changes the LED pin to use the built in aux LED on pin 16 on the TTGO board.