-
Notifications
You must be signed in to change notification settings - Fork 422
Update README.md #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update README.md #16
Conversation
Added English Readme too
📝 WalkthroughWalkthroughREADME.md receives a comprehensive new section on Open Source IoT System Design, featuring bilingual content in English and Chinese, along with imagery, installation and testing details, and extensive references to related documentation and licenses. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
README.md (2)
31-31: Duplicate heading "Design Internet of Things" breaks document structure.The same heading appears twice (lines 31 and 172), which violates Markdown conventions (MD024) and confuses navigation tools and readers. The document should either:
- Use distinct, descriptive headings for each section (e.g., "Design Internet of Things (Chinese)" and "Design Internet of Things (English)")
- Reorganize so bilingual content is grouped by topic rather than duplicated entirely
🔎 Suggested reorganization approach
Instead of repeating the entire structure, consider grouping bilingual content:
# Design Internet of Things ## 中文 / English ### 简介 / Overview [Chinese content] [English translation] ### 安装 / Installation [Chinese content] [English translation]This approach reduces duplication and makes maintenance easier.
Also applies to: 172-172
117-133: Eliminate duplicate link reference definitions.Link references [1]–[16] are defined twice (lines 117–133 and again at lines 262–278). This violates Markdown best practices (MD053) and creates confusion. Only the first definition is used by Markdown renderers, making the second set effectively ignored.
Consolidate into a single set of reference definitions, or reorganize the document structure to avoid duplication entirely.
Also applies to: 262-278
🧹 Nitpick comments (1)
README.md (1)
148-148: Wrap bare URLs in Markdown link syntax per markdownlint (MD034).Several URLs appear as bare text instead of wrapped in link references:
- Line 148: URL in the JD.com link text
- Line 164–170: Image with bare URL in href
- Line 204: Multiple bare URLs in the testing instructions
While functional, wrapping these in proper Markdown syntax improves consistency and passes linting checks.
Example for line 148:
- Buy now: [Amazon](...), [JD.com](http://search.jd.com/Search?keyword=...) + Buy now: [Amazon](...), [JD.com][jd-link] + + [jd-link]: http://search.jd.com/Search?keyword=...Also applies to: 164-170, 204-204
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
148-148: Bare URL used
(MD034, no-bare-urls)
168-168: Bare URL used
(MD034, no-bare-urls)
172-172: Multiple headings with the same content
(MD024, no-duplicate-heading)
204-204: Bare URL used
(MD034, no-bare-urls)
204-204: Bare URL used
(MD034, no-bare-urls)
262-262: Link and image reference definitions should be needed
Duplicate link or image reference definition: "1"
(MD053, link-image-reference-definitions)
263-263: Link and image reference definitions should be needed
Duplicate link or image reference definition: "2"
(MD053, link-image-reference-definitions)
264-264: Link and image reference definitions should be needed
Duplicate link or image reference definition: "3"
(MD053, link-image-reference-definitions)
265-265: Link and image reference definitions should be needed
Duplicate link or image reference definition: "4"
(MD053, link-image-reference-definitions)
266-266: Link and image reference definitions should be needed
Duplicate link or image reference definition: "5"
(MD053, link-image-reference-definitions)
267-267: Bare URL used
(MD034, no-bare-urls)
268-268: Bare URL used
(MD034, no-bare-urls)
269-269: Bare URL used
(MD034, no-bare-urls)
270-270: Bare URL used
(MD034, no-bare-urls)
271-271: Bare URL used
(MD034, no-bare-urls)
272-272: Bare URL used
(MD034, no-bare-urls)
273-273: Bare URL used
(MD034, no-bare-urls)
274-274: Bare URL used
(MD034, no-bare-urls)
275-275: Bare URL used
(MD034, no-bare-urls)
276-276: Bare URL used
(MD034, no-bare-urls)
277-277: Bare URL used
(MD034, no-bare-urls)
278-278: Bare URL used
(MD034, no-bare-urls)
|
|
||
|  | ||
|
|
||
| Buy now: [Amazon](https://www.amazon.cn/dp/B01IBZWTWW/ref=wl_it_dp_o_pC_nS_ttl?_encoding=UTF8&colid=BDXF90QZX6WX&coliid=I19EB97K0GNLW8), [JD.com](http://search.jd.com/Search?k eyword=%E8%87%AA%E5%B7%B1%E5%8A%A8%E6%89%8B%E8%AE%BE%E8%AE%A1%E7%89%A9%E8%81%94%E7%BD%91&enc=utf-8&wq=%E8%87%AA%E5%B7%B1%E5%8A%A8%E6%89%8B%E8%AE%BE%E8%AE%A1%E7%89%A9%E8%81%94%E7%BD%91&pvid=k24y6hri.l4xi28) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix spacing errors in URLs and text.
Several typos with unexpected spaces break URL references:
- Line 148:
k eyword→keyword - Line 267:
bare-mini mum-iot-system-create-restful→bare-minimum-iot-system-create-restful - Line 271:
dat e-commucation→date-commucation - Line 276:
http:// www→http://www
These appear to be formatting/copy errors and will render incorrectly or break links.
🔎 Proposed fixes for spacing errors
- Buy now: [Amazon](https://www.amazon.cn/dp/B01IBZWTWW/ref=wl_it_dp_o_pC_nS_ttl?_encoding=UTF8&colid=BDXF90QZX6WX&coliid=I19EB97K0GNLW8), [JD.com](http://search.jd.com/Search?k eyword=%E8%87%AA%E5%B7%B1%E5%8A%A8%E6%89%8B%E8%AE%BE%E8%AE%A1%E7%89%A9%E8%81%94%E7%BD%91&enc=utf-8&wq=%E8%87%AA%E5%B7%B1%E5%8A%A8%E6%89%8B%E8%AE%BE%E8%AE%A1%E7%89%A9%E8%81%94%E7%BD%91&pvid=k24y6hri.l4xi28)
+ Buy now: [Amazon](https://www.amazon.cn/dp/B01IBZWTWW/ref=wl_it_dp_o_pC_nS_ttl?_encoding=UTF8&colid=BDXF90QZX6WX&coliid=I19EB97K0GNLW8), [JD.com](http://search.jd.com/Search?keyword=%E8%87%AA%E5%B7%B1%E5%8A%A8%E6%89%8B%E8%AE%BE%E8%AE%A1%E7%89%A9%E8%81%94%E7%BD%91&enc=utf-8&wq=%E8%87%AA%E5%B7%B1%E5%8A%A8%E6%89%8B%E8%AE%BE%E8%AE%A1%E7%89%A9%E8%81%94%E7%BD%91&pvid=k24y6hri.l4xi28)- [6]:http://www.phodal.com/blog/bare-mini mum-iot-system-create-restful/
+ [6]:http://www.phodal.com/blog/bare-minimum-iot-system-create-restful/- [10]:http://www.phodal.com/blog/bare-minimum-iot-system-dat e-commucation/
+ [10]:http://www.phodal.com/blog/bare-minimum-iot-system-date-commucation/- [15]:http:// www.phodal.com/blog/bare-minimum-iot-system-add-test-for-laravel/
+ [15]:http://www.phodal.com/blog/bare-minimum-iot-system-add-test-for-laravel/Also applies to: 267-267, 271-271, 276-276
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
148-148: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In README.md around lines 148, 267, 271 and 276, several URLs and tokens contain
stray spaces (e.g., "k eyword" on line 148, "bare-mini
mum-iot-system-create-restful" on line 267, "dat e-commucation" on line 271, and
"http:// www" on line 276) which break links; remove the stray spaces to restore
the correct tokens ("keyword", "bare-minimum-iot-system-create-restful",
"date-commucation", and "http://www") and verify each URL renders and navigates
correctly after the edits.
Added English Readme too
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.