Update boosting docs to introduce manual boosting#44
Open
Raindogjones wants to merge 3 commits intophoebe-project:release-2.5from
Open
Update boosting docs to introduce manual boosting#44Raindogjones wants to merge 3 commits intophoebe-project:release-2.5from
Raindogjones wants to merge 3 commits intophoebe-project:release-2.5from
Conversation
kecnry
reviewed
May 8, 2025
Member
kecnry
left a comment
kecnry
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Just a few small comments:
- can you rerun the output to avoid the error output not being able to connect to the passband server?
- For tutorials, I personally prefer to rewrite all dictionary twig-access using set/get methods instead with specific tags (
b.set_value(qualifier='sma', component='binary', value=...)) to make it clear where parameters belong, to be efficient, and to try to stay consistent, but if you think this is easier to understand/maintain I won't insist.
Author
|
Sorry, I'm a twig man so wrote it as I would write all my scripts. Hopefully more in line with the style of the rest of the docs now! |
-Version bump in all docs (2.4->2.5) -Update to atm_passbands to include new atmospheres -New advanced atmosphere doc (atm_advanced) to explain ModelAtmosphere class and model atmosphere coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.