Open
Conversation
As mysql_list_fields() was removed from mysqlnd we should throw Error here I guess ... php/php-src@398caf9#diff-48eed863ec9451a1280e0e2d1d8e45b0
Member
|
I believe the better way is to export the function only when it can be
used. Then a user can check via `function_exists()`. By throwing an
error the user has no way to handle this gracefully.
…On Di, 2018-02-06 at 09:47 +0000, Andreas Schnederle-Wagner wrote:
As mysql_list_fields() was removed from mysqlnd we should throw Error
here I guess ...
***@***.***#diff-48eed863ec9451a1280e0e2d1d8e45b0
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
Update php_mysql.c
File Changes
M php_mysql.c (4)
Patch Links:
https://github.com/php/pecl-database-mysql/pull/1.patch
https://github.com/php/pecl-database-mysql/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Author
|
guess you are right - would be the more sophisticated approach to this ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mysql_list_fields() was removed from mysqlnd we should throw Error here I guess ...
php/php-src@398caf9#diff-48eed863ec9451a1280e0e2d1d8e45b0