Skip to content

Conversation

@MonkoftheFunk
Copy link

to be reviewed and remove any coinops specific changes

inigomonyota and others added 30 commits April 15, 2023 13:00
Fixes displaying of JPG images.  libjpeg-8.dll was present but unsure if it was ever being used.
Should videos be h265 it should set thread-type 2 as well
This may help with stability with systems with high core count.  Default behavior seems to set max-threads to whatever logical core count is.  No need to thread that much.  RetroFE with this change results in near half the thread usage (140~ down to 80~).  Needs testing further.
Considering set_state is asynchronous, theoretically playbin_ could be set to NULL before its state is actually GST_STATE_NULL which could leave its resources leaking.
Attempted to reduce time spent inside mutexes.  Seems to reduce GPU usage.  Especially on low end systems.  Further testing needed.
Will filter out GST_MESSAGE_EOS itself without having to check all messages with an if statement.
Due to removing mutexes entirely it can stay, added gst_structure_free(s) to unref it
unsure if SDL is already handling this
Configurable in settings.conf.  vSync = yes/no
Defaults to no when not present.  Default behavior is to lower the ranking of the specified GStreamer decoder plugins.
vSync should be the only thing limiting vsync if vSync is yes.
…_type

Fix reloadable video playlist type
made MaxThreads property of avdech264 and avdech265 configurable in settings.conf
MonkoftheFunk and others added 29 commits June 6, 2023 11:31
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fix

* changelog
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fix

* changelog

* improve layout error log

* fix playlist menu flash after playing a lastplayed game

* cl
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* disabled name jump for lastplayed
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* disabled name jump for lastplayed

* add setting to randomly choose a layout, for those who can't decide. randomLayout=layoutARCADES,layoutCASCADING,layoutSPIN

* changelog
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* disabled name jump for lastplayed

* add setting to randomly choose a layout, for those who can't decide. randomLayout=layoutARCADES,layoutCASCADING,layoutSPIN

* changelog

* added controls*.conf to be applied based on theme layout, useful for horizontal and vertical

* intial layout remap
not working yet

* not yet working

* logs

* not working

* refactor config to make it easier to override

* update changelog

* <reloadableImage/Video randomLimit="3"
will look for
image - <1-3>

* fix

* rename to randomSelect

* kiosk=F3 mode that locks navigation, quit, playlist toggle, fav toggle

* add isLocked yes/no reloadable image

* fix

* add kiosk=true setting

* fix controls for multiple layout files

* changelog

* changelog
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fixed kiosk image toggle
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* added controls*.conf to be applied based on theme layout, useful for horizontal and vertical

* intial layout remap
not working yet

* not yet working

* logs

* not working

* refactor config to make it easier to override

* update changelog

* jbPause now pauses attract mode

* not working

* 11

* 22

* 333

* working

* fixes

* fix

* changelog
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fix loading other layout - 1.xml

* rvrt
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fix

* fixed

* cl
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* initial untested quick key combo joyButton6+7

* working
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* movr
<menu additive="true">
Windows will be titled "RetroFE 0" "RetroFE 1" ect based on monitor number
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* update changelog
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* i think this improves things

* increased number of setting files to 14
* SDL2 2.28

* rebase (CoinOPS-Official#72)

* Move changelog (CoinOPS-Official#69)

* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* movr

* Additive blend mode

<menu additive="true">

* Add unique window names

Windows will be titled "RetroFE 0" "RetroFE 1" ect based on monitor number

* Additive fix, fixed improper postMessage declaration

---------

Co-authored-by: Tobias Contreras <tobias.ca@gmail.com>

---------

Co-authored-by: Tobias Contreras <tobias.ca@gmail.com>
* update gst 1.22.3 to 1.22.4

* Revert "use getScreenCount in render( )"

This reverts commit a49357a.

* Revert "Revert "use getScreenCount in render( )""

This reverts commit a23af69.

* Revert "Revert "Revert "use getScreenCount in render( )"""

This reverts commit c00df61.
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* able to get performance improvement without the flickering

* cl

* fix
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fix fading in videos
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* untested but compiles

* better, still not rendering normaly

* closer, can't select items but can scroll playlists and crashes on exit

* i think this is working better

* fix start layout to collection

* revert

* revert

* cl

* oops
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fix

* fix

* fix
* don't cycle playlist if on "street fighter and capcom fighters" or "street fighter"

* lower errors to warnings in logs

* - fixed sort to be more supportive of sort types (monkofthefunk)
 - fixed playcount as an reloadableimage (monkofthfunk)
 - improve restart video fast scroll flicker (monkofthefunk)

* fixed reload playcount after launch for images

* linuxfix

* fix

* fixed high GPU due to marquee rendering thread on game launch

* fix

---------

Co-authored-by: inigomonyota <96964704+inigomonyota@users.noreply.github.com>
BP Files/Page.cpp
BP Files/RetroFE.cpp
/.vs
/RetroFE/Builds
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be reverted except /.vs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants