Fix: missing gravity term in set_trajectory() function#9
Open
marvin-oh wants to merge 1 commit intophy-q:masterfrom
Open
Fix: missing gravity term in set_trajectory() function#9marvin-oh wants to merge 1 commit intophy-q:masterfrom
marvin-oh wants to merge 1 commit intophy-q:masterfrom
Conversation
|
@marvin-oh Did you need to make any changes to successfully run RandomAgent or PigShooter? |
Author
|
I found that both RandomAgent and PigShooter, which use SimpleTrajectoryPlanner.set_trajectory(), are not hitting the target location exactly. After applying the revised code, they reach the intended point precisely. But, I recommend verifying it in your own environment since this work was done quite long ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in SimpleTrajectoryPlanner.set_trajectory() function.
There was a missing term for gravity in the calculation of the y-axis position of the parabolic equation.
Fixes #8
Type of change