Skip to content

Fix: missing gravity term in set_trajectory() function#9

Open
marvin-oh wants to merge 1 commit intophy-q:masterfrom
marvin-oh:patch-1
Open

Fix: missing gravity term in set_trajectory() function#9
marvin-oh wants to merge 1 commit intophy-q:masterfrom
marvin-oh:patch-1

Conversation

@marvin-oh
Copy link

@marvin-oh marvin-oh commented Jun 6, 2024

Description

Fixes a bug in SimpleTrajectoryPlanner.set_trajectory() function.
There was a missing term for gravity in the calculation of the y-axis position of the parabolic equation.

Fixes #8

Type of change

  • Bug fix
  • New feature
  • Breaking change

@tellarin
Copy link

@marvin-oh Did you need to make any changes to successfully run RandomAgent or PigShooter?

@marvin-oh
Copy link
Author

I found that both RandomAgent and PigShooter, which use SimpleTrajectoryPlanner.set_trajectory(), are not hitting the target location exactly. After applying the revised code, they reach the intended point precisely.

But, I recommend verifying it in your own environment since this work was done quite long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correction needed for the calculation in SimpleTrajectoryPlanner.set_trajectory() function

2 participants