added support for ADFS xml through updated search locations...#1
Open
trickpatty wants to merge 1 commit intophylp:masterfrom
Open
added support for ADFS xml through updated search locations...#1trickpatty wants to merge 1 commit intophylp:masterfrom
trickpatty wants to merge 1 commit intophylp:masterfrom
Conversation
…ture and Assertion elements
Owner
|
Thanks for the PR @trickpatty! I am reluctant to merge this, however, since the purpose of this fork is to maintain SAML20's dependencies and anything else that would be a blocker for NPM audits. It was not intended to augment the original library's functionality. I would be willing to merge this, however, if the proper unit test/s were added. |
|
Hi @trickpatty @phylp. I am mainting a fork here if you folks are interested - https://github.com/boxyhq/saml20-maintained. I have pulled in this PR into the main branch there - ory/saml20#5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...for Signature and Assertion elements
ensures that the elements can be found for tokens delivered with the latest version of ADFS.