Add memoization to avoid rerenders when position is the same#210
Open
logovaser wants to merge 1 commit intopierpo:masterfrom
Open
Add memoization to avoid rerenders when position is the same#210logovaser wants to merge 1 commit intopierpo:masterfrom
logovaser wants to merge 1 commit intopierpo:masterfrom
Conversation
logovaser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdaptedArrowcomponent takes a while to render even though it's only noticeable when there are many connections visible. There's no need to render them again if the position is stale.I made this simple solution for my project and it does the job. You may come up with the better one, but I'd highly appreciate this change to be included. Sorry, I wasn't able to run/compile your project correctly due to lack of time, so just posting this concept.
Thanks for your work.