This repository was archived by the owner on Sep 9, 2024. It is now read-only.
Adding the ability to set up Automated Builds#68
Open
zeroshade wants to merge 6 commits intopierrec:masterfrom
Open
Adding the ability to set up Automated Builds#68zeroshade wants to merge 6 commits intopierrec:masterfrom
zeroshade wants to merge 6 commits intopierrec:masterfrom
Conversation
added 6 commits
September 14, 2018 13:52
Owner
|
Hello, I need to look at this as I am not familiar with appveyor. Thanks. |
Contributor
|
I'd also like to see support for prebuilt binaries in lz4. However, I don't think appveyor is needed either. I believe the standard practice for doing prebuilt binaries for Node packages is to use https://www.npmjs.com/package/prebuild-install (for downloading the binaries when a user installs)+ https://www.npmjs.com/package/prebuild (for creating the binaries and uploading them). Here is an example of how I added it another package: https://github.com/Venemo/node-lmdb/pull/148/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We built a module that depends on this lz4 module, but due to the utilities used by our consumers several do not easily have access to install
windows-build-toolsand build the package themselves locally. As a result, it makes more sense to publish pre-built binaries (as referred to in #67, I work with Mike who posted that issue).In here I've added an appveyor.yml file which can be used to set up an appveyor job that pre-builds windows versions of the library, and set up the package.json to utilize
node-pre-gypto check and download assets from releases in github.I've also updated the usage of the lz4 library to fix warnings of deprecated functions, and updated a couple of the dependencies. In my testing this works and the resulting tar.gz file is able to be downloaded and installed by
node-pre-gyp. In order to use this, an appveyor.yml project would need to be created and connected to this repo, along with putting a github token (encrypted via appveyor similar to the way travis works) into the yml file in order to allow it to deploy and publish the binaries. Would these be things you'd be willing to do after merging this?I've also condensed the compiled binary into a single lz4.node file since that was easier for specifying the artifacts and telling node-pre-gyp how to package things.