[WIP]: Conversion to CMake build system. #60
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shymega
force-pushed
the
cmake
branch
3 times, most recently
from
bddf029 to
0a683c2
Compare
|
Sorry if this is unsolicited feedback, but why CMake over Meson? |
Member
Author
|
@Newbytee Because I, and other maintainers, are more experienced with CMake, and prefer it over Meson. We're also looking to integrate Rust with the codebase, and CMake handles this better, in my experience with similar initiatives. CMake is also older, and has an established ecosystem. |
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Also: - Expand on CMakeLists.txt files Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Main work by @nicka101. Also, by @shymega: - Add another `target_link_libraries` to util_sha256 This links to CMSIS and HAL libs. - Fixup Dockerfile for GCC ARM download, and tidy - Had to run `dos2unix` on some files. - Remove `*.cmake` from .gitignore This allows us to keep future CMake modules, for example, Corrosion. - Update devcontainer.json name - Move `.devcontainer/devcontainer.json` to root of repo Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with the team, this is a draft PR for the conversion of Makefiles to CMake.
This means enhanced IDE/editor support, easier code FFI with Rust, and easier maintenance.
This PR may be force-pushed at points, but eventually, will be squashed when ready.
For now, it's a draft, and contributions are welcome via reviews.