Mark old GC APIs and messages as deprecated#1333
Open
MyonKeminta wants to merge 2 commits intopingcap:masterfrom
Open
Mark old GC APIs and messages as deprecated#1333MyonKeminta wants to merge 2 commits intopingcap:masterfrom
MyonKeminta wants to merge 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
JaySon-Huang
approved these changes
Nov 4, 2025
|
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…precate-old-gc-api
rleungx
approved these changes
Nov 5, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: tikv/pd#8978
If this update causes your repo reporting compilation warnings or errors complaining about using deprecated code, it means your repo still has code using some obsolete APIs. For these code:
GetGCSafePoint(V2),UpdateGCSafePoint(V2)->GetGCStates,GetAllKeyspacesGCStatesUpdateServiceGCSafePoint(V2)->SetGCBarrier,DeleteGCBarrier,SetGlobalGCBarrier,DeleteGlobalGCBarrier//nolint:staticcheck(for golang) or#[allow(deprecated)](for rust),